fix(auth): localize WeChat OAuth messages#4907
Open
neow021 wants to merge 2 commits into
Open
Conversation
- Route current-user WeChat and custom OAuth responses through backend i18n. - Add matching en, zh-CN, and zh-TW messages. - Keep admin custom OAuth management endpoints unchanged.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughAdds i18n keys and locale translations, and replaces hardcoded OAuth/WeChat controller messages with i18n-backed API errors and a sentinel-based WeChat error mapping. ChangesOAuth/WeChat i18n Support
Sequence DiagramsequenceDiagram
participant WeChatAuth as WeChatAuth/WeChatBind
participant getWeChatIdByCode as getWeChatIdByCode
participant apiWeChatError as apiWeChatError
participant ApiErrorI18n as common.ApiErrorI18n
WeChatAuth->>getWeChatIdByCode: request with code
alt code empty
getWeChatIdByCode-->>WeChatAuth: errWeChatInvalidCode
else verification failed or missing data
getWeChatIdByCode-->>WeChatAuth: errWeChatVerificationFailed
end
WeChatAuth->>apiWeChatError: map sentinel error
apiWeChatError->>ApiErrorI18n: return localized ApiErrorI18n
ApiErrorI18n-->>WeChatAuth: localized error response
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
controller/wechat.go (1)
31-50:⚠️ Potential issue | 🟠 Major | ⚡ Quick winUse
common.DecodeJsoninstead ofencoding/jsonin controller code.Line 49 uses
json.NewDecoder(...).Decode(&res), which violates the project's requirement that all JSON operations in business code must use wrapper functions fromcommon/json.go.Proposed fix
import ( - "encoding/json" "errors" "fmt" "net/http" "net/url" @@ var res wechatLoginResponse - err = json.NewDecoder(httpResponse.Body).Decode(&res) + err = common.DecodeJson(httpResponse.Body, &res) if err != nil { return "", err }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@controller/wechat.go` around lines 31 - 50, The function getWeChatIdByCode uses encoding/json directly (json.NewDecoder(...).Decode(&res)); replace that decoding with the project's wrapper: call common.DecodeJson(httpResponse.Body, &res) and handle its returned error similarly. Update references to wechatLoginResponse and ensure you still defer httpResponse.Body.Close() and propagate the error from common.DecodeJson in the same manner the current code does.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@controller/wechat.go`:
- Around line 31-50: The function getWeChatIdByCode uses encoding/json directly
(json.NewDecoder(...).Decode(&res)); replace that decoding with the project's
wrapper: call common.DecodeJson(httpResponse.Body, &res) and handle its returned
error similarly. Update references to wechatLoginResponse and ensure you still
defer httpResponse.Body.Close() and propagate the error from common.DecodeJson
in the same manner the current code does.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 3484d3e1-35bb-469e-94eb-11dd61d26094
📒 Files selected for processing (6)
controller/custom_oauth.gocontroller/wechat.goi18n/keys.goi18n/locales/en.yamli18n/locales/zh-CN.yamli18n/locales/zh-TW.yaml
6639835
approved these changes
May 16, 2026
- Decode WeChat login responses through common.DecodeJson. - Remove direct encoding/json use from the touched controller.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
📝 变更描述 / Description
Localize user-facing WeChat OAuth login/bind responses and current-user custom OAuth binding responses through the existing backend i18n layer.
This removes hardcoded Chinese responses from ordinary user auth flows, adds matching
en,zh-CN, andzh-TWlocale keys, and keeps admin custom OAuth provider management endpoints unchanged.🚀 变更类型 / Type of change
🔗 关联任务 / Related Issue
✅ 提交前检查项 / Checklist
Bug fix，我已提交或关联对应 Issue，且不会将设计取舍、预期不一致或理解偏差直接归类为 bug。📸 运行证明 / Proof of Work
gofmt -w controller/custom_oauth.go controller/wechat.go i18n/keys.gogo test ./controller ./i18ngit diff --checki18n/locales/en.yaml,zh-CN.yaml, andzh-TW.yamlSummary by CodeRabbit