-
-
Notifications
You must be signed in to change notification settings - Fork 34
[Rewrite] Wiki base structure #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rewrite] Wiki base structure #52
Conversation
75be899
to
7780a64
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Just a few typos, formatting, and wording that could be clearer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple more things I missed in the first pass, and a question.
Now that you tried using the Javadocs *cough, cough*, here is an alternate explanation: | ||
|
||
1. We instantiate a new builder. Using this, we can configure the `FoodComponent` before finally turning it into a proper `FoodComponent`. Note that all the following values are by default 0, false or empty. | ||
2. We set the hunger to 2, which corresponds to one of the total 10 drumsticks in Minecraft. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason to use the actual numbers here (after 1)?
It seems like it's just slightly more work to update should a new version ever add a new food component setting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mainly because this way the markdown is also quite readable, so mostly personal preference. I didn't apply the changes directly because it broke somehow and started overriding stuff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some feedback for the block article, I decided to leave it at that or I'd rewrite half the item tutorial. one overall comment:
we need a convention on capitalisation. I suggest "Adding a block, using block states, working with entities" (lowercase everything like QM) over the current "Adding a Block, using BlockState
s, working with Entities", since there's no clear convention here.
Co-authored-by: Will <[email protected]>
Let me know if this is ready to merge and ill put a 5 day FCP on it |
I do not plan on adding anthing new to this PR (The scope is already way to big), and all review seem to be resolved, so I'd be fine with merging. But I'm unsure about the accessebility of the page layout (I did some minor CSS hackery), it'd be great if someone who knows this stuff a bit could take a look. I also plan on PRs to:
|
Sounds good. Merging this in 5 days. |
Should I wait until this is merged to PR the QMJ wiki page? |
Create Item
tutorialCreate Block
tutorialFood Item
tutorial