refactor: rename verboseMode to compactMode for better UX clarity#3075
refactor: rename verboseMode to compactMode for better UX clarity#3075tanzhenxin merged 1 commit intomainfrom
Conversation
The "Compact Mode" label is more intuitive than "Verbose Mode" for users, as it directly describes the default compact view experience. This change inverts the boolean semantics (compactMode=false means show full output) and exposes the setting in the /settings dialog (showInDialog: true). - Rename ui.verboseMode → ui.compactMode with inverted default (false) - Rename VerboseModeContext → CompactModeContext (file and exports) - Rename TOGGLE_VERBOSE_MODE → TOGGLE_COMPACT_MODE in key bindings - Update all consumer components with inverted logic - Update i18n keys across 6 locales (verbose → compact) - Update VS Code settings schema - Add ui.compactMode documentation to settings.md - Fix Ctrl+O description in keyboard-shortcuts.md
📋 Review SummaryThis PR renames 🔍 General Feedback
🎯 Specific Feedback🟡 High Priority
🟢 Medium Priority
🔵 Low Priority
✅ Highlights
|
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
tanzhenxin
left a comment
There was a problem hiding this comment.
Review
Clean, mechanical rename of ui.verboseMode → ui.compactMode with correctly inverted boolean semantics throughout. All 22 files are consistent — schema, context, keybindings, UI consumers, i18n (6 locales), docs, tests, and snapshots.
Verdict
APPROVE — One minor note: users who manually set ui.verboseMode in their settings.json will have the key silently ignored (no migration). Impact is low since the old setting was hidden from the /settings dialog.
…enLM#3075) The "Compact Mode" label is more intuitive than "Verbose Mode" for users, as it directly describes the default compact view experience. This change inverts the boolean semantics (compactMode=false means show full output) and exposes the setting in the /settings dialog (showInDialog: true). - Rename ui.verboseMode → ui.compactMode with inverted default (false) - Rename VerboseModeContext → CompactModeContext (file and exports) - Rename TOGGLE_VERBOSE_MODE → TOGGLE_COMPACT_MODE in key bindings - Update all consumer components with inverted logic - Update i18n keys across 6 locales (verbose → compact) - Update VS Code settings schema - Add ui.compactMode documentation to settings.md - Fix Ctrl+O description in keyboard-shortcuts.md
Context
Closes #3047. Related: #2770 / #2767.
PR #2770 introduced a verbose/compact mode toggle (Ctrl+O) with the setting named
ui.verboseMode. However:/settingsdialog (showInDialog: false), making it undiscoverableThis PR renames the setting to
ui.compactModeand exposes it in/settings.Changes
Setting rename with inverted semantics
ui.verboseModeui.compactModetrue(show full output)false(show full output)/settingsDefault behavior is unchanged — users see full tool output by default in both old and new versions.
Breaking change
Users who have manually set
ui.verboseModein their settings.json will need to migrate toui.compactMode(with inverted value). The old key is silently ignored.Files changed
settingsSchema.ts,settings.schema.json— setting definitionVerboseModeContext.tsxrenamed toCompactModeContext.tsxkeyBindings.ts—TOGGLE_VERBOSE_MODErenamed toTOGGLE_COMPACT_MODEAppContainer,Footer,HistoryItemDisplay,MainContent,ToolGroupMessage,ToolMessage— inverted boolean logicsettings.md(addedui.compactModeentry),keyboard-shortcuts.md(fixed Ctrl+O description)ToolMessage.test.tsx,keyMatchers.test.ts, Footer snapshotTest plan
npm run buildpassesToolMessage,Footer,keyMatcherstests passverboseMode/VerboseModereferences remain in codebase/settingsdialog shows "Compact Mode" toggleui.compactMode