This repository was archived by the owner on Sep 8, 2023. It is now read-only.
Update Readme/Credits, Wyze Lock Support, Light/Bulb Scene Fix, Streamlining Logging#8
Merged
RMCob merged 25 commits intoRMCob:masterfrom Oct 18, 2021
Merged
Update Readme/Credits, Wyze Lock Support, Light/Bulb Scene Fix, Streamlining Logging#8RMCob merged 25 commits intoRMCob:masterfrom
RMCob merged 25 commits intoRMCob:masterfrom
Conversation
Updated to 638 to avoid error generated in Homekit log
Accidentally called previous commit "Wyze Lock v2" when there is only one version of the lock currently.
Accidentally called previous commit "Wyze Lock v2" when there is only one version of the lock currently.
Accidentally called previous commit "Wyze Lock v2" when there is only one version of the lock currently.
Accidentally called previous commit "Wyze Lock v2" when there is only one version of the lock currently.
Accidentally called previous commit "Wyze Lock v2" when there is only one version of the lock currently.
Accidentally called previous commit "Wyze Lock v2" when there is only one version of the lock currently.
testing in master how dare I
Running a scene with multiple Wyze Lights could result in issues setting power state, brightness, color, etc. This adds a 0.5s delay between each call.
Running a scene with multiple Wyze Lights could result in issues setting power state, brightness, color, etc. This adds a 0.5s delay between each call.
Running a scene with multiple Wyze Lights could result in issues setting power state, brightness, color, etc. This adds a 0.5s delay between each call.
Testing shortening the delay between calls
Testing shortening delay between calls
Moving logging of light changes to debug for clean up
Moving logging of light changes to debug for clean up
Moving logging of light changes to debug for clean up
coledeb
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
List of changes made in this pull request:
I personally have not been able to test the Wyze Lock functionality, as I do not own a Wyze Lock. User u/nsh02 on the Homebridge subreddit, who has been using my previously created fork/pull request, confirmed that their Wyze Lock is now able to be seen, as well as actioned on after testing this version.
I can confirm that I experienced issues with my Wyze Color Bulbs not always turning off, changing color properly etc. when part of a Scene with other Bulbs (while using the current plugin), and the fix implemented seems to have resolved this. I do not see any broken functionality or newly introduced errors in my personal use of this version (sans Wyze Lock of course).