Skip to content

[fix](dsv4): fix dsv4 accuracy error - #1809

Merged
valarLip merged 12 commits into
mainfrom
fix_dsv4
Aug 13, 2026
Merged

valarLip merged 12 commits into
mainfrom
fix_dsv4

Conversation

@PerryZhang01

Copy link
Copy Markdown
Contributor

Motivation

Technical Details

Test Plan

Test Result

Submission Checklist

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

🏷️ CI Guide

Runs automatically on every eligible PR before approval:

  • ✅ Pre Checkin: Black, Ruff, catalog schema validation, non-GPU unit tests

Heavy model tests:

  • ✅ Run after the PR is approved and Pre Checkin passes
  • ✅ Run immediately when an approval review is submitted
  • ✅ Can be requested before approval with labels
Label Tests
ci:full Run all heavy PR model tests: native ATOM, vLLM, and SGLang
ci:atom Run native ATOM model accuracy tests
ci:vllm Run ATOM vLLM OOT model accuracy tests
ci:sglang Run ATOM SGLang model accuracy tests

Heavy jobs are skipped when the PR is not approved and no matching ci:* label is present.
Add labels via the sidebar or gh pr edit 1809 --add-label <label>

@zufayu
zufayu requested a review from JiaoliangYu August 7, 2026 01:26
JiaoliangYu
JiaoliangYu previously approved these changes Aug 7, 2026

@JiaoliangYu JiaoliangYu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

PerryZhang01 and others added 3 commits August 11, 2026 19:09
Provide separate read/write slot buffers so DeepSeek-V4 graph warmup honors the content-addressed state contract.

Co-authored-by: Cursor <cursoragent@cursor.com>
xytpai and others added 6 commits August 11, 2026 22:09
Group DeepSeek-V4 aliases in one import block to keep the plugin module concise.

Co-authored-by: Cursor <cursoragent@cursor.com>
Apply Ruff's required alias-import layout and remove the extra test-module blank line so reviewdog reports no I001 findings.

Co-authored-by: Cursor <cursoragent@cursor.com>
Keep related DeepSeek-V4 aliases in one block while using scoped isort directives so Pre Checkin formatting remains green.

Co-authored-by: Cursor <cursoragent@cursor.com>
Avoid collecting model_runner when AITER is unavailable so the shared non-GPU Pre Checkin suite can complete.

Co-authored-by: Cursor <cursoragent@cursor.com>
@valarLip
valarLip merged commit eac7903 into main Aug 13, 2026
49 of 64 checks passed
@valarLip
valarLip deleted the fix_dsv4 branch August 13, 2026 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants