Repository navigation
fix(mla): migrate Triton decode to maintained aiter API - #2669
Merged
Merged
Conversation
Contributor
🏷️ CI GuideRuns automatically on every eligible PR before approval:
Heavy model tests:
|
valarLip
approved these changes
Oct 21, 2026
ZLkanyo009
added a commit
that referenced
this pull request
Oct 26, 2026
No conflicts. Picks up #2669 (fix(mla): migrate Triton decode to maintained aiter API): the 10-20 heavy accuracy jobs failed at import with ModuleNotFoundError: aiter.ops.triton.attention.mla_decode, raised from this branch's old triton_mla.py against the current aiter wheel, so a re-run of that merge ref would fail the same way. Co-authored-by: Cursor <cursoragent@cursor.com>
ZLkanyo009
added a commit
that referenced
this pull request
Oct 26, 2026
No conflicts. Picks up #2669 (fix(mla): migrate Triton decode to maintained aiter API): the 10-20 heavy accuracy jobs failed at import with ModuleNotFoundError: aiter.ops.triton.attention.mla_decode, raised from this branch's old triton_mla.py against the current aiter wheel, so a re-run of that merge ref would fail the same way. Co-authored-by: Cursor <cursoragent@cursor.com>
8 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aiter removed
aiter.ops.triton.attention.mla_decodein ROCm/aiter#6633. With current ATOM and aiter main, importing the Kimi MLA/GDN backend raisesModuleNotFoundErroreven when Triton MLA is disabled; the Triton decode path also depends on the deleted module.Use the maintained
aiter.ops.triton.attention.mla.mla_decode_fwdAPI for both plain and shuffled KV caches. View plain token rows as scheduler-sized pages and pass the existing block tables, context lengths, query offsets, and FP8 scales. Remove the obsolete CSR-to-dense conversion and decode scratch buffers from the Triton metadata builder.Validation in
jun_atom2with aiter main atb3ad6c4617:git diff --checkpassed.Full-model end-to-end inference has not been run.