CI: Temporarily use old vllm nightly image#1999
Merged
gyohuangxin merged 1 commit intomainfrom Feb 7, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Pins the vLLM benchmark workflow’s base container image to a specific rocm/vllm-dev nightly digest to keep CI stable while the moving nightly tag is unreliable.
Changes:
- Update
BASE_IMAGEfromrocm/vllm-dev:nightlyto a digest-pinnedrocm/vllm-dev:nightly@sha256:....
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -14,7 +14,7 @@ concurrency: | |||
| env: | |||
| VLLM_BRANCH: "main" | |||
| VLLM_REPOSITORY_URL: "https://github.com/vllm-project/vllm" | |||
There was a problem hiding this comment.
BASE_IMAGE is now pinned to a specific digest, which disables the intended "nightly" updates. Since the PR is described as temporary, consider adding a short inline comment (and ideally an issue/PR link or an expiration/removal criterion) so it’s clear when and why this should be reverted/updated.
Suggested change
| VLLM_REPOSITORY_URL: "https://github.com/vllm-project/vllm" | |
| VLLM_REPOSITORY_URL: "https://github.com/vllm-project/vllm" | |
| # TODO: Temporarily pin nightly base image to a known-good digest to avoid breaking CI; revert to `rocm/vllm-dev:nightly` once nightly images are stable again or the underlying issue is resolved. |
valarLip
pushed a commit
that referenced
this pull request
Mar 18, 2026
AMD-yanfeiwang
pushed a commit
to AMD-yanfeiwang/aiter
that referenced
this pull request
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.