[CI][CK_TILE] Update CK and fix fmha_fwd arg init#2334
Conversation
🏷️ CI GuideRuns automatically on every PR:
Extended tests (opt-in via labels):
|
There was a problem hiding this comment.
Pull request overview
Updates the Composable Kernel (CK) submodule and adjusts FMHA forward argument initialization to match CK’s updated fmha_fwd_args layout so Nightly CI compiles successfully.
Changes:
- Bump
3rdparty/composable_kernelsubmodule to commite5683e2290.... - Add the two newly required
fmha_fwd_argsfields (num_head_q_total,head_start) to the FMHA forward argument list.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| csrc/cpp_itfs/mha_fwd.cu | Adds two arguments to align with CK’s updated fmha_fwd_args struct layout. |
| 3rdparty/composable_kernel | Updates CK submodule revision to the version that introduced the struct layout change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| a.hdim_v, | ||
| a.nhead_q, | ||
| a.nhead_k, | ||
| 0, // num_head_q_total | ||
| 0, // head_start | ||
| a.scale_s, | ||
| a.logits_soft_cap, | ||
| a.stride_q, |
There was a problem hiding this comment.
For non-head-sliced paths, keeping these fields as 0 is fine. CK treats them as optional and uses internal fallback behavior for the default (non-sliced) case.
hyoon1
force-pushed
the
fix/nightly-ci-ck-fmha-fwd
branch
from
af75cb8 to
ba1680c
Compare
hyoon1
changed the title
Motivation
Nightly CI failed at compile-time in
mha_fwd.cuwith the latest CK.Technical Details
CK_TILE fmha_fwd_args added new fields (num_head_q_total, head_start).
Insert two arguments in order to match updated struct layout.
3rdparty/composable_kernelsubmodule toe5683e22902109f7652d2a1c3d39ed4c525f90efcsrc/cpp_itfs/mha_fwd.cuTest Plan
Test Result
Submission Checklist