Repository navigation
Conversation
…lection #5116 removed aiter/ops/flydsl/utils.py and swept every caller that existed in main at the time. op_tests/test_fused_moe_s1_fuse_fp8q.py landed afterwards via #4994, whose CI base predated the removal, so it still imports the deleted helper. The two PRs touch disjoint paths, so git merged them without conflict and neither CI run could see the break. The import is module scope and feeds pytestmark, so collection aborts: File "op_tests/test_fused_moe_s1_fuse_fp8q.py", line 24 from aiter.ops.flydsl.utils import is_flydsl_available ModuleNotFoundError: No module named 'aiter.ops.flydsl.utils' This fails the whole file on any shard that picks it up (seen on MI300X shard 5/8). Main has had no completed Aiter Test run since #4994 landed, so it went unnoticed. Drop the import and the availability skipif, matching how #5116 handled the same guard in op_tests/flydsl_tests/test_flydsl_moe_a8w4.py. FlyDSL is a pinned hard dependency (flydsl==0.3.2 in requirements.txt), which is why #5116 retired the probe; the remaining gfx950 gate is unchanged. Test plan: - pytest op_tests/test_fused_moe_s1_fuse_fp8q.py -> 2 passed on gfx950 (previously ModuleNotFoundError at collection) - No references to aiter.ops.flydsl.utils or is_flydsl_available remain - black --check, compileall clean Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
🏷️ CI GuideRuns automatically on every PR:
Extended tests (opt-in via labels):
PR title tags & labels: |
Collaborator
|
reverted the bad one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
op_tests/test_fused_moe_s1_fuse_fp8q.pyimports a module that no longer exists, aborting collection of the whole file on any shard that picks it up: