Skip to content

Revert "[AMD][DSV4] Fix(fmoe): fuse stage-1 fp8 quant on the heuristic FlyDSL fallback" - #5227

Merged
valarLip merged 1 commit into
mainfrom
revert-4994-amd/s1-fuse-fp8q-heuristic
Sep 3, 2026
Merged

valarLip merged 1 commit into
mainfrom
revert-4994-amd/s1-fuse-fp8q-heuristic

Conversation

@valarLip

@valarLip valarLip commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Reverts #4994 due to bad quality

@valarLip
valarLip requested a review from a team September 3, 2026 05:25
@valarLip
valarLip merged commit 283e1d4 into main Sep 3, 2026
19 checks passed
@valarLip
valarLip deleted the revert-4994-amd/s1-fuse-fp8q-heuristic branch September 3, 2026 05:25
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

🏷️ CI Guide

Runs automatically on every PR:

  • ✅ Pre-checks (submodule verification, code formatting)
  • ✅ Aiter op tests (gfx942 + gfx950)
  • ✅ Triton tests on MI35X (only when aiter/ops/triton/** or related paths are changed)

Extended tests (opt-in via labels):

Label Tests
ci:gfx1250-ffm-triton Run the five-shard gfx1250 FFM Triton test suite
ci:triton-300x Run an additional Triton test job on MI300X in PRs; main branch always runs both MI35X and MI300X
multigpu Aiter multi-GPU tests on the 8-GPU runner
ci:sglang SGLang integration tests: DeepSeek-R1-MXFP4 accuracy, Qwen 3.5 accuracy
ci:atom ATOM benchmark: DeepSeek-R1-0528, GPT-OSS-120B
ci:atom_full ATOM accuracy suite for PR and main models from ATOM models_accuracy.json
ci:vllm vLLM benchmark: GPT-OSS-120B, DeepSeek-R1-0528, Kimi-K2.5
ci:all All standard extended tests (excludes ci:atom_full)

Only add ci:atom_full for FlyDSL or Triton upgrades.
Add labels via the sidebar or gh pr edit 5227 --add-label <label>

PR title tags & labels:
Component tags ([Triton/Gluon], [HIP], [CK], [ASM], ...) are added to the PR title and as PR labels automatically from the changed files and re-synced on every push — change-type tags like [fix]/[Perf], op tags like [MLA], and human labels (ci:*) are left untouched. Add the no-auto-title label to opt this PR out.

xiaofei-zheng added a commit to xiaofei-zheng/aiter that referenced this pull request Sep 7, 2026
Picks up the revert of ROCm#4994 (ROCm#5227), which deletes
op_tests/test_fused_moe_s1_fuse_fp8q.py. That file imports
aiter.ops.flydsl.utils, a module that does not exist on main, so it failed
at import on both MI35X and MI300X shard 5 and was the sole reason the
Aiter Test Gate went red on this PR -- unrelated to the MXFP4 dispatch
guard here.

No conflicts. The guard in aiter/fused_moe.py, the shuffle_scale pad
initialisation and the new dispatch/numerics test are unchanged; the only
file main and this branch both touched is aiter/fused_moe.py, where the
revert removes the stage-1 fp8-quant fusion and merges cleanly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant