Repository navigation
Revert "[AMD][DSV4] Fix(fmoe): fuse stage-1 fp8 quant on the heuristic FlyDSL fallback" - #5227
Merged
Merged
Conversation
…c FlyDSL…" This reverts commit 83571d9.
Contributor
🏷️ CI GuideRuns automatically on every PR:
Extended tests (opt-in via labels):
PR title tags & labels: |
xiaofei-zheng
added a commit
to xiaofei-zheng/aiter
that referenced
this pull request
Sep 7, 2026
Picks up the revert of ROCm#4994 (ROCm#5227), which deletes op_tests/test_fused_moe_s1_fuse_fp8q.py. That file imports aiter.ops.flydsl.utils, a module that does not exist on main, so it failed at import on both MI35X and MI300X shard 5 and was the sole reason the Aiter Test Gate went red on this PR -- unrelated to the MXFP4 dispatch guard here. No conflicts. The guard in aiter/fused_moe.py, the shuffle_scale pad initialisation and the new dispatch/numerics test are unchanged; the only file main and this branch both touched is aiter/fused_moe.py, where the revert removes the stage-1 fp8-quant fusion and merges cleanly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #4994 due to bad quality