Skip to content

fix(umbp): port test_peer_pool's FailingEngine to CreatePlanBuilder - #790

Merged
TianDi101 merged 1 commit into
mainfrom
fix/umbp-test-peer-pool-plan-builder
Oct 16, 2026
Merged

TianDi101 merged 1 commit into
mainfrom
fix/umbp-test-peer-pool-plan-builder

Conversation

@TianDi101

Copy link
Copy Markdown
Collaborator

Motivation

main does not build with BUILD_UMBP=ON. The mori umbp unit test (MI355X_AINIC) job fails at Build mori with UMBP on main's own push run for c999f41, and on every PR, because PR jobs build refs/pull/<n>/merge (e.g. #786, job 117015094714):

tests/cpp/umbp/distributed/test_peer_pool.cpp:194:70: error: only virtual member functions can be marked 'override'
tests/cpp/umbp/distributed/test_peer_pool.cpp:868:17: error: variable type 'FailingEngine' is an abstract class
  (unimplemented pure virtual method 'CreatePlanBuilder' — transfer_engine.h:398)

The cause is a semantic merge conflict between two PRs that did not conflict as text:

Technical Details

FailingEngine now delegates CreatePlanBuilder() to its wrapped LocalCopyEngine, the same way GatedEngine in the same file already does. This was the only stale Plan(...) override left in src/umbp or tests/cpp/umbp on main.

Test Plan

UMBP-only native build on an MI355X host (BUILD_UMBP=ON BUILD_TESTS=ON, other components off), then the test_peer_pool target and binary.

Test Result

  • ninja test_peer_pool: builds and links, with no errors.
  • test_peer_pool: 41/41 passed, including PeerPool.AFailedDemotionIsRetriedUntilItsBudgetRunsOut, the test that instantiates FailingEngine.
  • pre-commit hooks, including clang-format, pass.

🤖 Generated with Claude Code

#763 added FailingEngine with a `Plan(...) const override`, written
against a base older than #774. #774 made TransferEngine::Plan()
non-virtual and moved the planning hook to the pure virtual
CreatePlanBuilder(). #763 then merged without a rebase, so main fails
to build UMBP:

  test_peer_pool.cpp:194: error: only virtual member functions can be
  marked 'override'
  test_peer_pool.cpp:868: error: variable type 'FailingEngine' is an
  abstract class

Delegate CreatePlanBuilder() to the wrapped LocalCopyEngine, the same
way GatedEngine in this file already does.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@TianDi101
TianDi101 merged commit bba3dd8 into main Oct 16, 2026
12 of 25 checks passed
yangyuhuiling pushed a commit that referenced this pull request Oct 19, 2026
Picks up 11 commits, notably bba3dd8 (#790), which fixes test_peer_pool's
FailingEngine against the new CreatePlanBuilder interface. Without it the PR's
"mori umbp unit test" job fails to compile when run against current main, as
the /ci-rerun on 10-16 did; nothing in this PR touches UMBP.

No conflicts. The only file here near this PR's area is
src/cco/device/cco_device_wrapper.cpp (#786, new SDMA bitcode entry points),
which the AsyncLL kernels do not use.

Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant