Repository navigation
fix(umbp): port test_peer_pool's FailingEngine to CreatePlanBuilder - #790
Merged
Merged
Conversation
#763 added FailingEngine with a `Plan(...) const override`, written against a base older than #774. #774 made TransferEngine::Plan() non-virtual and moved the planning hook to the pure virtual CreatePlanBuilder(). #763 then merged without a rebase, so main fails to build UMBP: test_peer_pool.cpp:194: error: only virtual member functions can be marked 'override' test_peer_pool.cpp:868: error: variable type 'FailingEngine' is an abstract class Delegate CreatePlanBuilder() to the wrapped LocalCopyEngine, the same way GatedEngine in this file already does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
yangyuhuiling
pushed a commit
that referenced
this pull request
Oct 19, 2026
Picks up 11 commits, notably bba3dd8 (#790), which fixes test_peer_pool's FailingEngine against the new CreatePlanBuilder interface. Without it the PR's "mori umbp unit test" job fails to compile when run against current main, as the /ci-rerun on 10-16 did; nothing in this PR touches UMBP. No conflicts. The only file here near this PR's area is src/cco/device/cco_device_wrapper.cpp (#786, new SDMA bitcode entry points), which the AsyncLL kernels do not use. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
maindoes not build withBUILD_UMBP=ON. Themori umbp unit test (MI355X_AINIC)job fails at Build mori with UMBP on main's own push run forc999f41, and on every PR, because PR jobs buildrefs/pull/<n>/merge(e.g. #786, job 117015094714):The cause is a semantic merge conflict between two PRs that did not conflict as text:
cf77a37) madeTransferEngine::Plan()a non-virtual wrapper and moved the planning hook to the pure virtualCreatePlanBuilder().d6b23ed) addedFailingEnginewithPlan(...) const override. Its branch was last based on4a1e27b(feat(umbp): serve metrics from a masterless node, and summarise offload/load/evict/promote/demote at INFO #683), which is before refactor(umbp): one incremental plan builder shared by every transfer engine #774, so no CI ever built it against the new interface.Technical Details
FailingEnginenow delegatesCreatePlanBuilder()to its wrappedLocalCopyEngine, the same wayGatedEnginein the same file already does. This was the only stalePlan(...) overrideleft insrc/umbportests/cpp/umbpon main.Test Plan
UMBP-only native build on an MI355X host (
BUILD_UMBP=ON BUILD_TESTS=ON, other components off), then thetest_peer_pooltarget and binary.Test Result
ninja test_peer_pool: builds and links, with no errors.test_peer_pool: 41/41 passed, includingPeerPool.AFailedDemotionIsRetriedUntilItsBudgetRunsOut, the test that instantiatesFailingEngine.🤖 Generated with Claude Code