Repository navigation
[Bugfix] Upstream merge #2 to Transformers v5 fix - #986
Conversation
Signed-off-by: sfeng33 <4florafeng@gmail.com>
Signed-off-by: khluu <khluu000@gmail.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
vllm-project#44033) Signed-off-by: Bill Nell <bnell@redhat.com>
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com> Signed-off-by: qianlihuang <91178480+qianlihuang@users.noreply.github.com> Co-authored-by: Yiliu Dong <91178480+qianlihuang@users.noreply.github.com>
vllm-project#43792) Signed-off-by: Gagan Dhakrey <gagandhakrey@gmail.com>
…arsers (vllm-project#43997) Signed-off-by: sfeng33 <4florafeng@gmail.com>
Signed-off-by: Andreas Karatzas <akaratza@amd.com>
…guage support (vllm-project#43881) Signed-off-by: nemanjaudovic <nudovic@amd.com> Co-authored-by: Shengqi Chen <harry-chen@outlook.com>
…est_gpt_oss.py (vllm-project#43571) Signed-off-by: Ma, Liangliang <liangliang.ma@intel.com> Co-authored-by: Kunshang Ji <kunshang.ji@intel.com>
…lm-project#42379) Signed-off-by: Lanze Liu <lanzetech@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
…llm-project#43817) Signed-off-by: Xiaoran Chen <xiaoran@fb.com> Co-authored-by: Xiaoran Chen <xiaoran@fb.com>
…#44047) Signed-off-by: Bugen Zhao <i@bugenzhao.com>
…ory access was encountered` (vllm-project#43909) Signed-off-by: yewentao256 <zhyanwentao@126.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Signed-off-by: Woosuk Kwon <woosuk@inferact.ai>
…AMD Zen CPUs (vllm-project#41813) Signed-off-by: R <Ganesh.R@amd.com> Signed-off-by: Harshal Adhav <harshal.adhav@amd.com> Signed-off-by: Aakar Dwivedi <aadwived@amd.com> Co-authored-by: R <Ganesh.R@amd.com> Co-authored-by: Harshal Adhav <harshal.adhav@amd.com> Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Michael Goin <mgoin64@gmail.com>
…ct#43956) Signed-off-by: Jee Jee Li <jeejeelee@inferact.ai>
Co-authored-by: nightcityblade <nightcityblade@gmail.com>
…mpletion protocol validators (vllm-project#36254) Signed-off-by: umut-polat <52835619+umut-polat@users.noreply.github.com>
Signed-off-by: Lucas Wilkinson <lwilkins@redhat.com>
…lm-project#44035) Signed-off-by: esmeetu <jasonailu87@gmail.com> Signed-off-by: Jeffrey Wang <jeffreywang@anyscale.com> Signed-off-by: Nick Hill <nickhill123@gmail.com> Co-authored-by: esmeetu <jasonailu87@gmail.com> Co-authored-by: Nick Hill <nickhill123@gmail.com>
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
…ct#42730) Signed-off-by: wcy <233313160abc@gmail.com> Co-authored-by: Li, Jiang <jiang1.li@intel.com>
Signed-off-by: UranusSeven <109661872+UranusSeven@users.noreply.github.com>
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Signed-off-by: Will.hou <1205157517@qq.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Bugen Zhao <i@bugenzhao.com>
…model. (vllm-project#43770) Signed-off-by: zzt <zengzetang.zzt@antgroup.com> Co-authored-by: Jiangyun Zhu <riverclouds.zhu@qq.com>
… fixture (vllm-project#44146) Signed-off-by: Chaojun Zhang <chaojun.zhang@intel.com>
…erformance improvement (vllm-project#43706) Signed-off-by: yewentao256 <zhyanwentao@126.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
…llm-project#43992) Signed-off-by: Madeesh Kannan <madeeswaran.kannan@jetbrains.com> Co-authored-by: Robert Shaw <114415538+robertgshaw2-redhat@users.noreply.github.com>
…4161) Signed-off-by: Yongye Zhu <zyy1102000@gmail.com>
…tions (vllm-project#44177) Signed-off-by: Ronen Schaffer <ronen.schaffer@ibm.com>
…roject#43883) Signed-off-by: Maria Guevara <kawaiiplush14@gmail.com>
…nd KVCacheCoordinator (vllm-project#44165) Signed-off-by: Yifan Qiao <yifanqiao@inferact.ai>
Signed-off-by: omerpaz95 <omerpaz95@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
…m-project#42977) Signed-off-by: Alberto Perdomo <aperdomo@redhat.com>
…lm-project#44126) Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
…roject#43754) Signed-off-by: Rukhaiya <rukhaiya@c643n08aix1-lp1.pok.stglabs.ibm.com> Signed-off-by: Rukhaiya <bibirukhaiya123@gmail.com> Co-authored-by: Rukhaiya <rukhaiya@c643n08aix1-lp1.pok.stglabs.ibm.com> Co-authored-by: Akash kaothalkar <61960177+Akashcodes732@users.noreply.github.com> Co-authored-by: Li, Jiang <jiang1.li@intel.com>
…from event draining (vllm-project#44206) Signed-off-by: Ronen Schaffer <ronen.schaffer@ibm.com>
…ject#43421) Signed-off-by: Marceli Fylcek <marceli.fylcek@intel.com> Co-authored-by: Kunshang Ji <kunshang.ji@intel.com>
…lm-project#42971) Signed-off-by: Shreyas Kulkarni <shreyas.gp269@gmail.com>
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
vllm-project#42967) Signed-off-by: Amit Gruner <agruner@crusoe.ai> Co-authored-by: Amit Gruner <agruner@crusoe.ai> Co-authored-by: Jiangyun Zhu <riverclouds.zhu@qq.com>
… processor (vllm-project#44232) Signed-off-by: Luciano Martins <lucianommartins@users.noreply.github.com> Co-authored-by: Luciano Martins <lucianommartins@users.noreply.github.com>
Signed-off-by: tbarnatan <tbarnatan@nvidia.com> Co-authored-by: Michael Goin <mgoin64@gmail.com>
…v5 (vllm-project#44282) Signed-off-by: guanwei-wu <b08901019@ntu.edu.tw> Signed-off-by: wjinxu <1299461899@qq.com> Co-authored-by: guanwei-wu <b08901019@ntu.edu.tw> Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: <callumm@amd.com>
|
What do you mean by "The merge was done by cherry-picking individual commits"? I assume you were doing a "git merge upstream/main" to ensure that the merge-base etc are correctly recorded? |
This is what I did for the prior merge, but when checking Regardless, this created a messy situation where trying to do another |
|
Created an empty merge commit to bump the merge-base. From examining a diff between this branch and the upstream commit merged, all the remaining changes appear to be ROCm-specific additions and changes, or fork-exclusive github action jobs left out intentionally. |
Purpose
Pull upstream changes up to and including PR #44282 to fix Transformers v5 support.
The merge was done by cherry-picking individual commits starting from the last merge point, resolving conflicts as they arose, then validating the final result builds and passes a breadth of functionality tests (no new failures since before the merge), fixing any issues if present.
Minor performance regressions, if present, can be followed up on since this merge unblocks other important work.
Test Plan
Run similar merge verification tests to #983
Test Result
Correctness tests: no regressions
Attention performance tests: no new regressions since the last merge; a previous 22% qwen3.5_35b TRITON_ATTN is now back within tolerance.