Skip to content

[Bugfix] Upstream merge #2 to Transformers v5 fix - #986

Merged
mgehre-amd merged 1275 commits into
gfx11from
callumm.transformers_merge
Jun 5, 2026
Merged

mgehre-amd merged 1275 commits into
gfx11from
callumm.transformers_merge

Conversation

@amd-callumm

@amd-callumm amd-callumm commented Jun 5, 2026 •

Copy link
Copy Markdown

Purpose

Pull upstream changes up to and including PR #44282 to fix Transformers v5 support.

The merge was done by cherry-picking individual commits starting from the last merge point, resolving conflicts as they arose, then validating the final result builds and passes a breadth of functionality tests (no new failures since before the merge), fixing any issues if present.

Minor performance regressions, if present, can be followed up on since this merge unblocks other important work.

Test Plan

Run similar merge verification tests to #983

Test Result

Correctness tests: no regressions

Attention performance tests: no new regressions since the last merge; a previous 22% qwen3.5_35b TRITON_ATTN is now back within tolerance.

sfeng33 and others added 30 commits May 29, 2026 22:52
Signed-off-by: sfeng33 <4florafeng@gmail.com>
Signed-off-by: khluu <khluu000@gmail.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Signed-off-by: qianlihuang <91178480+qianlihuang@users.noreply.github.com>
Co-authored-by: Yiliu Dong <91178480+qianlihuang@users.noreply.github.com>
Signed-off-by: Andreas Karatzas <akaratza@amd.com>
…guage support (vllm-project#43881)

Signed-off-by: nemanjaudovic <nudovic@amd.com>
Co-authored-by: Shengqi Chen <harry-chen@outlook.com>
…est_gpt_oss.py (vllm-project#43571)

Signed-off-by: Ma, Liangliang <liangliang.ma@intel.com>
Co-authored-by: Kunshang Ji <kunshang.ji@intel.com>
…lm-project#42379)

Signed-off-by: Lanze Liu <lanzetech@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
…llm-project#43817)

Signed-off-by: Xiaoran Chen <xiaoran@fb.com>
Co-authored-by: Xiaoran Chen <xiaoran@fb.com>
…ory access was encountered` (vllm-project#43909)

Signed-off-by: yewentao256 <zhyanwentao@126.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Signed-off-by: Woosuk Kwon <woosuk@inferact.ai>
…AMD Zen CPUs (vllm-project#41813)

Signed-off-by: R <Ganesh.R@amd.com>
Signed-off-by: Harshal Adhav <harshal.adhav@amd.com>
Signed-off-by: Aakar Dwivedi <aadwived@amd.com>
Co-authored-by: R <Ganesh.R@amd.com>
Co-authored-by: Harshal Adhav <harshal.adhav@amd.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Michael Goin <mgoin64@gmail.com>
Co-authored-by: nightcityblade <nightcityblade@gmail.com>
…mpletion protocol validators (vllm-project#36254)

Signed-off-by: umut-polat <52835619+umut-polat@users.noreply.github.com>
Signed-off-by: Lucas Wilkinson <lwilkins@redhat.com>
…lm-project#44035)

Signed-off-by: esmeetu <jasonailu87@gmail.com>
Signed-off-by: Jeffrey Wang <jeffreywang@anyscale.com>
Signed-off-by: Nick Hill <nickhill123@gmail.com>
Co-authored-by: esmeetu <jasonailu87@gmail.com>
Co-authored-by: Nick Hill <nickhill123@gmail.com>
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
…ct#42730)

Signed-off-by: wcy <233313160abc@gmail.com>
Co-authored-by: Li, Jiang <jiang1.li@intel.com>
Signed-off-by: UranusSeven <109661872+UranusSeven@users.noreply.github.com>
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Signed-off-by: Will.hou <1205157517@qq.com>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Bugen Zhao <i@bugenzhao.com>
…model. (vllm-project#43770)

Signed-off-by: zzt <zengzetang.zzt@antgroup.com>
Co-authored-by: Jiangyun Zhu <riverclouds.zhu@qq.com>
… fixture (vllm-project#44146)

Signed-off-by: Chaojun Zhang <chaojun.zhang@intel.com>
…erformance improvement (vllm-project#43706)

Signed-off-by: yewentao256 <zhyanwentao@126.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
…llm-project#43992)

Signed-off-by: Madeesh Kannan <madeeswaran.kannan@jetbrains.com>
Co-authored-by: Robert Shaw <114415538+robertgshaw2-redhat@users.noreply.github.com>
ronensc and others added 16 commits June 3, 2026 15:03
…tions (vllm-project#44177)

Signed-off-by: Ronen Schaffer <ronen.schaffer@ibm.com>
…nd KVCacheCoordinator (vllm-project#44165)

Signed-off-by: Yifan Qiao <yifanqiao@inferact.ai>
Signed-off-by: omerpaz95 <omerpaz95@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
…m-project#42977)

Signed-off-by: Alberto Perdomo <aperdomo@redhat.com>
…roject#43754)

Signed-off-by: Rukhaiya <rukhaiya@c643n08aix1-lp1.pok.stglabs.ibm.com>
Signed-off-by: Rukhaiya <bibirukhaiya123@gmail.com>
Co-authored-by: Rukhaiya <rukhaiya@c643n08aix1-lp1.pok.stglabs.ibm.com>
Co-authored-by: Akash kaothalkar <61960177+Akashcodes732@users.noreply.github.com>
Co-authored-by: Li, Jiang <jiang1.li@intel.com>
…from event draining (vllm-project#44206)

Signed-off-by: Ronen Schaffer <ronen.schaffer@ibm.com>
…ject#43421)

Signed-off-by: Marceli Fylcek <marceli.fylcek@intel.com>
Co-authored-by: Kunshang Ji <kunshang.ji@intel.com>
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
vllm-project#42967)

Signed-off-by: Amit Gruner <agruner@crusoe.ai>
Co-authored-by: Amit Gruner <agruner@crusoe.ai>
Co-authored-by: Jiangyun Zhu <riverclouds.zhu@qq.com>
… processor (vllm-project#44232)

Signed-off-by: Luciano Martins <lucianommartins@users.noreply.github.com>
Co-authored-by: Luciano Martins <lucianommartins@users.noreply.github.com>
Signed-off-by: tbarnatan <tbarnatan@nvidia.com>
Co-authored-by: Michael Goin <mgoin64@gmail.com>
…v5 (vllm-project#44282)

Signed-off-by: guanwei-wu <b08901019@ntu.edu.tw>
Signed-off-by: wjinxu <1299461899@qq.com>
Co-authored-by: guanwei-wu <b08901019@ntu.edu.tw>
Co-authored-by: Cursor <cursoragent@cursor.com>
@amd-callumm amd-callumm changed the title [bugfix] Upstream merge #2 to Transformers v5 fix [Bugfix] Upstream merge #2 to Transformers v5 fix Jun 5, 2026
@amd-callumm
amd-callumm marked this pull request as ready for review June 5, 2026 14:11
@amd-callumm
amd-callumm requested a review from dllehr-amd as a code owner June 5, 2026 14:11
@mgehre-amd

Copy link
Copy Markdown

What do you mean by "The merge was done by cherry-picking individual commits"? I assume you were doing a "git merge upstream/main" to ensure that the merge-base etc are correctly recorded?

@amd-callumm

Copy link
Copy Markdown
Author

What do you mean by "The merge was done by cherry-picking individual commits"? I assume you were doing a "git merge upstream/main" to ensure that the merge-base etc are correctly recorded?

This is what I did for the prior merge, but when checking git merge-base upstream/main rocm/gfx11 again for this merge, the last shared baseline is apparently still at April 28. I thought that a merge would have updated this, but apparently not... In hindsight, I wonder if it's because I committed the previous merge PR to gfx11 with a squash-and-merge rather than a merge commit? IIRC this was the only method that allowed pushing the changes without further conflict resolution.

Regardless, this created a messy situation where trying to do another git merge upstream/main for this led to hundreds of files conflicting in complicated ways. The same goes for a rebase. Cherry-picking commits was far cleaner with only a few minor conflicts, and seemed like the only practical way forward without a huge time investment to attempt a proper rebase. Leaving it alone might create more challenges down the line, though...

@amd-callumm

Copy link
Copy Markdown
Author

Created an empty merge commit to bump the merge-base. From examining a diff between this branch and the upstream commit merged, all the remaining changes appear to be ROCm-specific additions and changes, or fork-exclusive github action jobs left out intentionally.

@mgehre-amd
mgehre-amd merged commit 1c9241f into gfx11 Jun 5, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.