Skip to content

fix(icon): polished icon #3956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Jul 14, 2025
Merged

fix(icon): polished icon #3956

merged 22 commits into from
Jul 14, 2025

Conversation

cscnk52
Copy link
Contributor

@cscnk52 cscnk52 commented Jun 19, 2025

Description

related to simple-icons/simple-icons#13443

The PR use re-optimized icon in simple-icons, waiting for simple-icons review. Reviewed

And request @DIYgod review in this repo.

To-dos

  • redraw icon
  • update icon in desktop
  • update icon in mobile
  • redraw RSSHub SVG icon (WIP)
  • update icon in docs and badge (This need wait for SimpleIcons and shields.io next release)

og diff:
before | after

Copy link

vercel bot commented Jun 19, 2025

@cscnk52 is attempting to deploy a commit to the RSS3 Team on Vercel.

A member of the Team first needs to authorize it.

@cscnk52 cscnk52 marked this pull request as draft June 19, 2025 02:43
@Innei
Copy link
Member

Innei commented Jun 19, 2025

Good job

@cscnk52 cscnk52 marked this pull request as ready for review July 6, 2025 17:31
@cscnk52 cscnk52 marked this pull request as draft July 6, 2025 17:47
@cscnk52
Copy link
Contributor Author

cscnk52 commented Jul 7, 2025

Simple-icons have been merged simple-icons/simple-icons#13443 , This PR still need to wait for Simple-icons and shields.io's next release, after that, we can simply add logo parameter to use Folo icon in badge.

https://img.shields.io/badge/Folo?logo=folo

@Innei
Copy link
Member

Innei commented Jul 14, 2025

Is this PR ready to be merged now? @cscnk52

@cscnk52
Copy link
Contributor Author

cscnk52 commented Jul 14, 2025

I still have other things about icon to do, but now, should merge this PR first.

In this PR, I change these things:

  • change Folo icon to redraw version

I change Folo SVG icon only contain path, so icon will be more clear, but, maybe some CSS class about Icon need to change, such as change under apps/desktop/layer/renderer/src/modules/entry-content/components/EntryPlaceholderLogo.tsx

  • change some third-party icon to Simple Icons version or self redraw

The icon file under packages/internal/components/src/ui/platform-icon/collections/ folder, I change most of it to Simple Icons version, and Cubox icon was redrawn by me, RSS3 icon scale it to full width.

  • unify icon viewbox to 24, merge path, remove unnecessary def g element in SVG

Unify SVG icon viewbox to 24, single path, compress SVG, transform Circle and other SVG Object to path, remove padding in icon.

  • improve SSR OG image generate

changed under apps/ssr/src/router/og/__base.tsx

see diff:

before | after


I also want to do these things, but not yet compleat:

  • redraw RSSHub version: I'm still learning SVG editing, maybe need few days.
  • change badge in README to official shields.io version: this requires shields.io update it's Simple-icons version to 15.6.0, still need to wait.

I will do above things in another PR.

Now This PR can be merged, please review it before merge.

@cscnk52 cscnk52 marked this pull request as ready for review July 14, 2025 08:21
@hyoban hyoban closed this in #4172 Jul 14, 2025
@hyoban hyoban reopened this Jul 14, 2025
@cscnk52 cscnk52 changed the title fix(icon): re-optimized icon fix(icon): polished icon Jul 14, 2025
Copy link
Member

@Innei Innei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@Innei Innei merged commit 0f9aa59 into RSSNext:dev Jul 14, 2025
8 of 10 checks passed
@follow-reviewer-bot
Copy link

Thank you for your contribution! 🎉

Your pull request has been merged and we really appreciate your help in making this project better. We hope to see more contributions from you in the future! 💪

@cscnk52 cscnk52 deleted the icon branch July 14, 2025 13:41
@cscnk52 cscnk52 mentioned this pull request Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants