Skip to content

[Feature] PR #9194 存在问题 | Unresolved thread on PR #9194 #9210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
polarvid opened this issue Jul 18, 2024 · 3 comments · Fixed by #9361
Closed

[Feature] PR #9194 存在问题 | Unresolved thread on PR #9194 #9210

polarvid opened this issue Jul 18, 2024 · 3 comments · Fixed by #9361
Labels
Arch: RISC-V BSP related with risc-v 🎯 Focus Should focus on this issue/discussion/pr

Comments

@polarvid
Copy link
Contributor

polarvid commented Jul 18, 2024

Describe problem solved by the proposed feature

存在未消解的 Change Request。需要给出合理拒绝理由,或进行正确修改。

#9194

另外,强烈质疑维护者不解决问题的作风。我是不是可以认为主线上 PR 的 review 过程本质是可有可无的。
同理可得,以后我们提交 PR 也不需要关心 Review 。毕竟合并就是这样随心所欲的行为。

Describe your preferred solution

No response

Describe possible alternatives

No response

@polarvid polarvid added the Arch: RISC-V BSP related with risc-v label Jul 18, 2024
@polarvid polarvid changed the title [Feature] pr#9194 存在问题 [Feature] PR #9194 存在问题 Jul 18, 2024
@polarvid polarvid changed the title [Feature] PR #9194 存在问题 [Feature] PR #9194 存在问题 | Unresolved thread on PR #9194 Jul 18, 2024
@unicornx
Copy link
Contributor

以后 PR 上 reviewer 提出的问题,建议 PR 的 author 都必须给予答复,accept OR reject,没有答复就开始重新提交是一种不礼貌的行为。

@BernardXiong BernardXiong added the 🎯 Focus Should focus on this issue/discussion/pr label Jul 24, 2024
@BernardXiong
Copy link
Member

这块存在问题的,都有change req的标记了,还合并了?

@BernardXiong
Copy link
Member

以后 PR 上 reviewer 提出的问题,建议 PR 的 author 都必须给予答复,accept OR reject,没有答复就开始重新提交是一种不礼貌的行为。

感觉这类都不是礼貌不礼貌的问题了,而是是否是合规性行为。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arch: RISC-V BSP related with risc-v 🎯 Focus Should focus on this issue/discussion/pr
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants