Skip to content

fix(klibc\kstdio): vsnprinf size_t can not exceed INT32_MAX, don't u… #10205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

liuyangzys
Copy link
Contributor

@liuyangzys liuyangzys commented Apr 21, 2025

…se (rt_size_t -1)

拉取/合并请求描述:(PR description)

[

开启RT_KLIBC_USING_LIBC_VSNPRINTF后,rt_vsprintf 执行异常。排查原因为 vsnprinf 的 size 参数不能超过 INT32 最大值。

编译器

arm-none-eabi-gcc v10.3.1

mcu

stm32h7xx

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@github-actions github-actions bot added the Kernel PR has src relate code label Apr 21, 2025
@supperthomas supperthomas requested a review from Copilot April 21, 2025 07:38
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses an issue with rt_vsprintf by ensuring that the size parameter passed to rt_vsnprintf does not exceed the maximum allowed value. The change replaces the previously used (rt_size_t)-1 with INT32_MAX to enforce the correct upper limit.

  • Changes rt_vsprintf to call rt_vsnprintf with INT32_MAX
  • Aligns the size parameter with the constraints of vsnprintf on target platforms
Comments suppressed due to low confidence (1)

src/klibc/kstdio.c:54

  • Replacing (rt_size_t)-1 with INT32_MAX enforces the correct maximum size for rt_vsnprintf. Please ensure that INT32_MAX is defined and available on all target platforms.
return rt_vsnprintf(buf, INT32_MAX, format, arg_ptr);

@liuyangzys liuyangzys changed the title fix(klibc\kstdio): vsnprinf size_t can not exceed UINT32_MAX, don't u… fix(klibc\kstdio): vsnprinf size_t can not exceed INT32_MAX, don't u… Apr 21, 2025
@liuyangzys
Copy link
Contributor Author

liuyangzys commented Apr 22, 2025

这个问题完全可以复现的,编译器直接就会警告。所有相关的rt_vsprintf数都会执行失败返回-1。感觉应该尽快修复

@supperthomas
Copy link
Member

rt_vsprintf

可否具体讲讲复现方法吗?这边ci检测看起来没有报warning。
https://github.com/RT-Thread/rt-thread/actions/runs/14599436945/job/40953639237

@supperthomas
Copy link
Member

rt_vsprintf

可否具体讲讲复现方法吗?这边ci检测看起来没有报warning。 https://github.com/RT-Thread/rt-thread/actions/runs/14599436945/job/40953639237

或者也可以把报错截图发出来

@supperthomas supperthomas added the -1 No vote label Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-1 No vote Kernel PR has src relate code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants