-
Couldn't load subscription status.
- Fork 5.3k
[bsp] [stm32] 添加鹿小班STM32H723开发板的BSP #10842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
📌 Code Review Assignment🏷️ Tag: bsp_stm32Reviewers: Liang1795 hamburger-os wdfk-prog Changed Files (Click to expand)
🏷️ Tag: workflowReviewers: Rbb666 kurisaW supperthomas Changed Files (Click to expand)
📊 Current Review Status (Last Updated: 2025-10-26 15:03 CST)
📝 Review Instructions
|
|
👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread! 为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。 🛠 操作步骤 | Steps
完成后,提交将自动更新至 如有问题欢迎联系我们,再次感谢您的贡献!💐 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds Board Support Package (BSP) for the LuXiaoBan (鹿小班) STM32H723 development board to the RT-Thread project.
Key changes:
- New BSP directory structure for stm32h723-lxb-disco board
- STM32CubeMX configuration files for hardware initialization
- Keil MDK project files and linker scripts
- Basic GPIO and LPUART1 driver configuration
Reviewed Changes
Copilot reviewed 32 out of 33 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| bsp/stm32/stm32h723-lxb-disco/rtconfig.py | Build configuration for GCC, Keil, and IAR toolchains |
| bsp/stm32/stm32h723-lxb-disco/rtconfig.h | RT-Thread kernel and component configuration |
| bsp/stm32/stm32h723-lxb-disco/board/board.h | Board-level definitions for memory layout |
| bsp/stm32/stm32h723-lxb-disco/board/board.c | System clock configuration implementation |
| bsp/stm32/stm32h723-lxb-disco/board/Kconfig | Hardware driver configuration menu |
| bsp/stm32/stm32h723-lxb-disco/applications/main.c | LED blink example application |
| bsp/stm32/stm32h723-lxb-disco/SConstruct | SCons build script with package validation |
| Various CubeMX files | STM32CubeMX generated peripheral initialization |
| Project files | Keil MDK project configuration and templates |
| # EXEC_PATH is the compiler execute path, for example, CodeSourcery, Keil MDK, IAR | ||
| if CROSS_TOOL == 'gcc': | ||
| PLATFORM = 'gcc' | ||
| EXEC_PATH = r'C:\Users\XXYYZZ' |
Copilot
AI
Oct 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
English: The hardcoded path 'C:\Users\XXYYZZ' appears to be a placeholder. This should either be removed or replaced with a more generic path comment.
中文:硬编码路径 'C:\Users\XXYYZZ' 看起来是一个占位符。这应该被删除或替换为更通用的路径注释。
| EXEC_PATH = r'C:\Users\XXYYZZ' | |
| EXEC_PATH = '' # TODO: Set this to your GCC toolchain path, e.g. r'C:\Program Files\GNU Tools Arm Embedded\bin' |
| #define STM32_FLASH_START_ADRESS ((uint32_t)0x08000000) | ||
| #define STM32_FLASH_SIZE (1024 * 1024) | ||
| #define STM32_FLASH_END_ADDRESS ((uint32_t)(STM32_FLASH_START_ADRESS + STM32_FLASH_SIZE)) |
Copilot
AI
Oct 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
English: Corrected spelling of 'ADRESS' to 'ADDRESS' in macro name.
中文:修正了宏名称中 'ADRESS' 的拼写为 'ADDRESS'。
| #define STM32_FLASH_START_ADRESS ((uint32_t)0x08000000) | |
| #define STM32_FLASH_SIZE (1024 * 1024) | |
| #define STM32_FLASH_END_ADDRESS ((uint32_t)(STM32_FLASH_START_ADRESS + STM32_FLASH_SIZE)) | |
| #define STM32_FLASH_START_ADDRESS ((uint32_t)0x08000000) | |
| #define STM32_FLASH_SIZE (1024 * 1024) | |
| #define STM32_FLASH_END_ADDRESS ((uint32_t)(STM32_FLASH_START_ADDRESS + STM32_FLASH_SIZE)) |
| #define RT_USING_DEVICE | ||
| #define RT_USING_CONSOLE | ||
| #define RT_CONSOLEBUF_SIZE 128 | ||
| #define RT_CONSOLE_DEVICE_NAME "hlpuart1" |
Copilot
AI
Oct 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
English: The console device name appears to have a typo. Should be "lpuart1" instead of "hlpuart1" (extra 'h' at the beginning).
中文:控制台设备名称似乎有拼写错误。应该是 "lpuart1" 而不是 "hlpuart1"(开头多了一个 'h')。
| #define RT_CONSOLE_DEVICE_NAME "hlpuart1" | |
| #define RT_CONSOLE_DEVICE_NAME "lpuart1" |
修复链接脚本中'excetion'拼写错误为'execution' 启用rtconfig.py中的环境变量配置选项
链接脚本中包含了所有寄存器,除flash与主sarm外其余寄存器已注释
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
为鹿小班STM32H723开发板添加BSP
你的解决方案是什么 (what is your solution)
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up