Skip to content

Conversation

@Pcb-yun
Copy link

@Pcb-yun Pcb-yun commented Oct 23, 2025

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

为鹿小班STM32H723开发板添加BSP

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:stm32/stm32h723-lxb-disco
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

@CLAassistant
Copy link

CLAassistant commented Oct 23, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added BSP: STM32 BSP related with ST/STM32 BSP action github action yml imporve labels Oct 23, 2025
@github-actions
Copy link

github-actions bot commented Oct 23, 2025

📌 Code Review Assignment

🏷️ Tag: bsp_stm32

Reviewers: Liang1795 hamburger-os wdfk-prog

Changed Files (Click to expand)
  • bsp/stm32/libraries/HAL_Drivers/drivers/config/h7/uart_config.h
  • bsp/stm32/stm32h723-lxb-disco/.config
  • bsp/stm32/stm32h723-lxb-disco/.gitignore
  • bsp/stm32/stm32h723-lxb-disco/Kconfig
  • bsp/stm32/stm32h723-lxb-disco/README.md
  • bsp/stm32/stm32h723-lxb-disco/README_zh.md
  • bsp/stm32/stm32h723-lxb-disco/SConscript
  • bsp/stm32/stm32h723-lxb-disco/SConstruct
  • bsp/stm32/stm32h723-lxb-disco/applications/SConscript
  • bsp/stm32/stm32h723-lxb-disco/applications/main.c
  • bsp/stm32/stm32h723-lxb-disco/board/.ignore_format.yml
  • bsp/stm32/stm32h723-lxb-disco/board/CubeMX_Config/.mxproject
  • bsp/stm32/stm32h723-lxb-disco/board/CubeMX_Config/CubeMX_Config.ioc
  • bsp/stm32/stm32h723-lxb-disco/board/CubeMX_Config/Inc/main.h
  • bsp/stm32/stm32h723-lxb-disco/board/CubeMX_Config/Inc/stm32h7xx_hal_conf.h
  • bsp/stm32/stm32h723-lxb-disco/board/CubeMX_Config/Inc/stm32h7xx_it.h
  • bsp/stm32/stm32h723-lxb-disco/board/CubeMX_Config/Src/main.c
  • bsp/stm32/stm32h723-lxb-disco/board/CubeMX_Config/Src/stm32h7xx_hal_msp.c
  • bsp/stm32/stm32h723-lxb-disco/board/CubeMX_Config/Src/stm32h7xx_it.c
  • bsp/stm32/stm32h723-lxb-disco/board/CubeMX_Config/Src/system_stm32h7xx.c
  • bsp/stm32/stm32h723-lxb-disco/board/Kconfig
  • bsp/stm32/stm32h723-lxb-disco/board/SConscript
  • bsp/stm32/stm32h723-lxb-disco/board/board.c
  • bsp/stm32/stm32h723-lxb-disco/board/board.h
  • bsp/stm32/stm32h723-lxb-disco/board/linker_scripts/link.icf
  • bsp/stm32/stm32h723-lxb-disco/board/linker_scripts/link.lds
  • bsp/stm32/stm32h723-lxb-disco/board/linker_scripts/link.sct
  • bsp/stm32/stm32h723-lxb-disco/figures/board.png
  • bsp/stm32/stm32h723-lxb-disco/project.uvoptx

🏷️ Tag: workflow

Reviewers: Rbb666 kurisaW supperthomas

Changed Files (Click to expand)
  • .github/ALL_BSP_COMPILE.json

📊 Current Review Status (Last Updated: 2025-10-26 15:03 CST)

  • Liang1795 Pending Review
  • Rbb666 Pending Review
  • hamburger-os Pending Review
  • kurisaW Pending Review
  • supperthomas Pending Review
  • wdfk-prog Pending Review

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@github-actions
Copy link

👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).


🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录(目录请以"/"结尾)
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to:stm32h723-lxb-disco
  • 设置PR number为 \ Set the PR number to:10842
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后,提交将自动更新至 stm32h723-lxb-disco 分支,关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the stm32h723-lxb-disco branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们,再次感谢您的贡献!💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@supperthomas supperthomas requested a review from Copilot October 24, 2025 02:17
@supperthomas supperthomas added the BSP: new bsp board New added bsp, need sync action label Oct 24, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds Board Support Package (BSP) for the LuXiaoBan (鹿小班) STM32H723 development board to the RT-Thread project.

Key changes:

  • New BSP directory structure for stm32h723-lxb-disco board
  • STM32CubeMX configuration files for hardware initialization
  • Keil MDK project files and linker scripts
  • Basic GPIO and LPUART1 driver configuration

Reviewed Changes

Copilot reviewed 32 out of 33 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
bsp/stm32/stm32h723-lxb-disco/rtconfig.py Build configuration for GCC, Keil, and IAR toolchains
bsp/stm32/stm32h723-lxb-disco/rtconfig.h RT-Thread kernel and component configuration
bsp/stm32/stm32h723-lxb-disco/board/board.h Board-level definitions for memory layout
bsp/stm32/stm32h723-lxb-disco/board/board.c System clock configuration implementation
bsp/stm32/stm32h723-lxb-disco/board/Kconfig Hardware driver configuration menu
bsp/stm32/stm32h723-lxb-disco/applications/main.c LED blink example application
bsp/stm32/stm32h723-lxb-disco/SConstruct SCons build script with package validation
Various CubeMX files STM32CubeMX generated peripheral initialization
Project files Keil MDK project configuration and templates

# EXEC_PATH is the compiler execute path, for example, CodeSourcery, Keil MDK, IAR
if CROSS_TOOL == 'gcc':
PLATFORM = 'gcc'
EXEC_PATH = r'C:\Users\XXYYZZ'
Copy link

Copilot AI Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

English: The hardcoded path 'C:\Users\XXYYZZ' appears to be a placeholder. This should either be removed or replaced with a more generic path comment.
中文:硬编码路径 'C:\Users\XXYYZZ' 看起来是一个占位符。这应该被删除或替换为更通用的路径注释。

Suggested change
EXEC_PATH = r'C:\Users\XXYYZZ'
EXEC_PATH = '' # TODO: Set this to your GCC toolchain path, e.g. r'C:\Program Files\GNU Tools Arm Embedded\bin'

Copilot uses AI. Check for mistakes.
Comment on lines +23 to +25
#define STM32_FLASH_START_ADRESS ((uint32_t)0x08000000)
#define STM32_FLASH_SIZE (1024 * 1024)
#define STM32_FLASH_END_ADDRESS ((uint32_t)(STM32_FLASH_START_ADRESS + STM32_FLASH_SIZE))
Copy link

Copilot AI Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

English: Corrected spelling of 'ADRESS' to 'ADDRESS' in macro name.
中文:修正了宏名称中 'ADRESS' 的拼写为 'ADDRESS'。

Suggested change
#define STM32_FLASH_START_ADRESS ((uint32_t)0x08000000)
#define STM32_FLASH_SIZE (1024 * 1024)
#define STM32_FLASH_END_ADDRESS ((uint32_t)(STM32_FLASH_START_ADRESS + STM32_FLASH_SIZE))
#define STM32_FLASH_START_ADDRESS ((uint32_t)0x08000000)
#define STM32_FLASH_SIZE (1024 * 1024)
#define STM32_FLASH_END_ADDRESS ((uint32_t)(STM32_FLASH_START_ADDRESS + STM32_FLASH_SIZE))

Copilot uses AI. Check for mistakes.
#define RT_USING_DEVICE
#define RT_USING_CONSOLE
#define RT_CONSOLEBUF_SIZE 128
#define RT_CONSOLE_DEVICE_NAME "hlpuart1"
Copy link

Copilot AI Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

English: The console device name appears to have a typo. Should be "lpuart1" instead of "hlpuart1" (extra 'h' at the beginning).
中文:控制台设备名称似乎有拼写错误。应该是 "lpuart1" 而不是 "hlpuart1"(开头多了一个 'h')。

Suggested change
#define RT_CONSOLE_DEVICE_NAME "hlpuart1"
#define RT_CONSOLE_DEVICE_NAME "lpuart1"

Copilot uses AI. Check for mistakes.
修复链接脚本中'excetion'拼写错误为'execution'
启用rtconfig.py中的环境变量配置选项
链接脚本中包含了所有寄存器,除flash与主sarm外其余寄存器已注释
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action github action yml imporve BSP: new bsp board New added bsp, need sync action BSP: STM32 BSP related with ST/STM32 BSP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants