Skip to content

Conversation

@ComerLater
Copy link
Contributor

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

目前仓库中代码格式化有clang-format、formatting.py、as.sh等,为了响应#10764#10391

你的解决方案是什么 (what is your solution)

(1)将所有的.ignore_format.yml通过python脚本转换为.clang-format-ignore,
(2)删除.ignore_format.yml,同时修改format_ignore.pyfile_check.py中相关代码读取.clang-format-ignore信息
(3)删除ci中formatting.py相关功能,采用clang-format自动格式化,并对所有代码进行一次完整格式化

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

@github-actions
Copy link

📌 Code Review Assignment

🏷️ Tag: bsp_cvitek

Reviewers: @unicornx

Changed Files (Click to expand)
  • bsp/cvitek/drivers/.clang-format-ignore

🏷️ Tag: bsp_hc32

Reviewers: @levizh

Changed Files (Click to expand)
  • bsp/hc32/libraries/.clang-format-ignore
  • bsp/hc32l136/.clang-format-ignore
  • bsp/hc32l196/.clang-format-ignore

📊 Current Review Status (Last Updated: 2025-10-25 23:48 CST)


📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@github-actions github-actions bot added BSP: NXP Code related with NXP BSP: STM32 BSP related with ST/STM32 BSP tools BSP: Renesas BSP related with Renesas BSP: GD32 BSP related with GD32 BSP: Infineon BSP related with Infineon BSP: Cvitek BSP related with cvitek component: net BSP: AT32 BSP related with AT32 BSP: WCH BSP related with WCH Component component: drivers/usb component: net/lwip component: drivers labels Oct 25, 2025
@github-actions
Copy link

👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).


🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录(目录请以"/"结尾)
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to:clang-format-ignore
  • 设置PR number为 \ Set the PR number to:10853
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后,提交将自动更新至 clang-format-ignore 分支,关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the clang-format-ignore branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们,再次感谢您的贡献!💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@kurisaW
Copy link
Member

kurisaW commented Oct 25, 2025

第一点不建议在此pr中修改,目前已经交给夏令营同学去修改了,并且也不是一味转换脚本,有些路径已经失效,并且可以高效整合一下重复逻辑

建议作者完成第二第三点即可,此外自动转换脚本不建议提交上来

麻烦作者再修改一下,感谢pr贡献

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BSP: AT32 BSP related with AT32 BSP: Cvitek BSP related with cvitek BSP: GD32 BSP related with GD32 BSP: Infineon BSP related with Infineon BSP: NXP Code related with NXP BSP: Renesas BSP related with Renesas BSP: STM32 BSP related with ST/STM32 BSP: WCH BSP related with WCH BSP component: drivers/usb component: drivers component: net/lwip component: net Component tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants