Skip to content

Add tabular.data.ui.theme light and dark options #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
RandomFractals opened this issue Jan 16, 2022 · 5 comments
Closed

Add tabular.data.ui.theme light and dark options #80

RandomFractals opened this issue Jan 16, 2022 · 5 comments
Labels
feature

Comments

@RandomFractals
Copy link
Owner

See Tabulator themes doc to add it to the default table view display with Tabulator table: http://tabulator.info/docs/5.0/theme

And Perspective Viewer theming doc to add it for the new Perspective view added in #65:

https://perspective.finos.org/docs/md/js.html#theming
RandomFractals added a commit that referenced this issue Jan 17, 2022
@RandomFractals
set perspective viewer bg color to vscode editor bg for now (#80)
a8297b3 
for the perspective viewer controls and filter panel to match vscode editor background color
RandomFractals added a commit that referenced this issue Jan 17, 2022
@RandomFractals
refine table view toolbar bottom border styling (#80)
af4c88a
@RandomFractals
Copy link
Owner Author

RandomFractals commented Jan 18, 2022 •
edited
Loading

new Perspective grid view with vscode theme background color used for the Columns/View control panel and Filter section:

image

RandomFractals added a commit that referenced this issue Jan 22, 2022
@RandomFractals
add light/dark UI theme config setting (#80)
28c2271 
and capitalize Settings enums
@RandomFractals RandomFractals changed the title Add tabular.data.view.theme light and dark options Add tabular.data.ui.theme light and dark options Jan 22, 2022
RandomFractals added a commit that referenced this issue Jan 22, 2022
@RandomFractals
load dark tabulator and perspective stylesheets for dark data UI them…
079149b 
…e views (#80)
@RandomFractals
Copy link
Owner Author

dark perspective view display:

image

@RandomFractals
Copy link
Owner Author

Tabulator midnight theme CSS might need some refinements (too light gray and garish)

image

RandomFractals added a commit that referenced this issue Jan 23, 2022
@RandomFractals
add tabular.data.view type and ui.theme settings to docs (#75 & #80)
a885fc0
@RandomFractals
Copy link
Owner Author

will refine Tabulator dark/midnight UI theme later.

This feature covers the basics for the light & dark UI theme users to view their data in those color palettes.

RandomFractals added a commit that referenced this issue Jan 23, 2022
@RandomFractals
add a note to docs to reopen table views for view type and UI theme s…
1d75675 
…ettings changes to take effect (#75 & #80)
@RandomFractals
Copy link
Owner Author

see updated settings section in docs: https://github.com/RandomFractals/tabular-data-viewer#settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RandomFractals