Skip to content

Book 3.10.2: Section 10.2 lacks required updates to hittable_list.h #1318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hollasch opened this issue Oct 27, 2023 · 1 comment
Closed

Book 3.10.2: Section 10.2 lacks required updates to hittable_list.h #1318

hollasch opened this issue Oct 27, 2023 · 1 comment
Assignees
@hollasch
Labels
book 3: Your Life level: patch
Milestone
v4.0.0

Comments

@hollasch
Copy link
Collaborator

Benny Tsang writes:

(Book 3) In order to correctly render Image 10, we also need an updated version of hittable_list.h that includes the pdf_value and random member functions.
@hollasch hollasch added this to the v4.0.0 milestone Oct 27, 2023
@hollasch hollasch self-assigned this Oct 27, 2023
@k4lizen k4lizen mentioned this issue Dec 15, 2023
Closed
@hollasch hollasch assigned rupsis and unassigned hollasch Feb 10, 2024
@hollasch hollasch changed the title Section 10.2 lacks required updates to hittable_list.h Book 3.10.2: Section 10.2 lacks required updates to hittable_list.h Apr 19, 2024
@hollasch hollasch mentioned this issue Apr 25, 2024
Closed
hollasch added a commit that referenced this issue Apr 25, 2024
@hollasch
Avoid hittable_list of lights until ready
d267078 
The previous version didn't work be we hadn't yet added the
`pdf_value()` and `random` functions to the `hittable_list` class, so
all of these scenes (images 3.10-13) rendered as fully dark.

Resolves #1318
@hollasch hollasch mentioned this issue Apr 25, 2024
Merged
@hollasch hollasch assigned hollasch and unassigned rupsis Apr 25, 2024
@hollasch
Copy link
Collaborator Author

Note that this is a duplicate of #1267. Just found this now, so I'll continue using this one as the canonical issue.

@hollasch hollasch mentioned this issue Apr 25, 2024
Closed
hollasch added a commit that referenced this issue Apr 25, 2024
@hollasch
Avoid hittable_list of lights until ready
b98d19a 
The previous version didn't work be we hadn't yet added the
`pdf_value()` and `random` functions to the `hittable_list` class, so
all of these scenes (images 3.10-13) rendered as fully dark.

Resolves #1318
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hollasch hollasch

Labels
book 3: Your Life level: patch
Projects
None yet
Milestone
v4.0.0
Development

No branches or pull requests
2 participants
@hollasch @rupsis