Skip to content

aarect.h lacks override keyword on some methods #748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
trevordblack opened this issue Oct 6, 2020 · 0 comments
Closed

aarect.h lacks override keyword on some methods #748

trevordblack opened this issue Oct 6, 2020 · 0 comments

Comments

@trevordblack
Copy link
Collaborator

In file included from /home/lucifer/writing/raytracing.github.io/src/TheRestOfYourLife/main.cc:14:
/home/lucifer/writing/raytracing.github.io/src/TheRestOfYourLife/aarect.h:58:24: warning: 'pdf_value' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
        virtual double pdf_value(const point3& origin, const vec3& v) const {
                       ^
/home/lucifer/writing/raytracing.github.io/src/TheRestOfYourLife/hittable.h:50:24: note: overridden virtual function is here
        virtual double pdf_value(const vec3& o, const vec3& v) const {
                       ^
In file included from /home/lucifer/writing/raytracing.github.io/src/TheRestOfYourLife/main.cc:14:
/home/lucifer/writing/raytracing.github.io/src/TheRestOfYourLife/aarect.h:70:22: warning: 'random' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
        virtual vec3 random(const point3& origin) const {
                     ^
/home/lucifer/writing/raytracing.github.io/src/TheRestOfYourLife/hittable.h:54:22: note: overridden virtual function is here
        virtual vec3 random(const vec3& o) const {
@trevordblack trevordblack added this to the v3.2.2 milestone Oct 6, 2020
@trevordblack trevordblack self-assigned this Oct 6, 2020
@hollasch hollasch changed the title Warnings thrown out: aarect.h lacks override keyword on some methods Oct 10, 2020
hollasch added a commit that referenced this issue Oct 11, 2020
@hollasch hollasch assigned hollasch and unassigned trevordblack Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants