-
Notifications
You must be signed in to change notification settings - Fork 921
Typo and off-by-one error in stratifying/jittering section of Book 3 #976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Milestone
Comments
Thanks. I'll look into it. |
This is a sibling issue to #682 |
Yes, this is being addressed in issue #682. |
Fixed the typo in ongoing changes for #682. |
|
I've fixed it in the feature branch (not yet on GitHub). |
Ref #993 |
Two issues here. One is fixed, and the other is addressed in #682. Closing. |
trevordblack
pushed a commit
that referenced
this issue
Jun 8, 2023
trevordblack
pushed a commit
that referenced
this issue
Jun 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I have noticed a small typo in the stratifying section of Book 3 of the dev-major v4 branch. The typo is in listing 6.
int sqrt_spp = int(sqrt(samples_per_pixrel));
Also, in listing 6, I believe there is an off-by-one error. This has existed since v3 of Book 3 and the accompanying reference source code.
Should be:
And also in the final scene.h source code.
The text was updated successfully, but these errors were encountered: