Skip to content

Book 3.10.1: camera::ray_color() switches from double pdf to double pdf_val halfway through #988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
trevordblack opened this issue Feb 4, 2022 · 4 comments
Closed

Book 3.10.1: camera::ray_color() switches from double pdf to double pdf_val halfway through #988

trevordblack opened this issue Feb 4, 2022 · 4 comments
Assignees
@hollasch
Labels
book 3: Your Life level: patch
Milestone
v4.0.0

Comments

@trevordblack
Copy link
Collaborator

Pick one of the above and make it consistent.
@trevordblack trevordblack added this to the v4.0.0 milestone Feb 4, 2022
@trevordblack trevordblack self-assigned this Feb 4, 2022
@trevordblack trevordblack mentioned this issue Feb 4, 2022
Merged
@trevordblack trevordblack modified the milestones: v4.0.0, v4.0.0-books23 Jun 19, 2023
@hollasch hollasch modified the milestones: v4.0.0-book3, v4.0.0 Jul 20, 2023
@hollasch
Copy link
Collaborator

This is a local variable in camera::ray_color(). Also confusing versus hittable::pdf_value().

@hollasch hollasch assigned hollasch and unassigned trevordblack Apr 19, 2024
@hollasch hollasch changed the title Book 3 scene.h source switches from double pdf to double pdf_val halfway through Book 3.10.1: camera::ray_color() switches from double pdf to double pdf_val halfway through Apr 19, 2024
@hollasch
Copy link
Collaborator

hollasch commented Apr 22, 2024 •
edited
Loading

pdf clashes with the class name. pdf_value clashes with hittable::pdf_value(), though that should be ok as a local name.

@hollasch
Copy link
Collaborator

Ugh. The material classes all use pdf as the PDF value parameter. I think I'll let these slide for now.

hollasch added a commit that referenced this issue Apr 23, 2024
@hollasch
Updates from book 3 complete progression
77471af 
Also includes some minor fixes.

Note that this shows the current state of some buggy renders, which
render the entire scene as black, except for the single square light
source.

Resolves #988
Resolves #1317
@hollasch hollasch mentioned this issue Apr 23, 2024
Merged
hollasch added a commit that referenced this issue Apr 23, 2024
@hollasch
Updates from book 3 complete progression
07b339c 
Also includes some minor fixes.

Note that this shows the current state of some buggy renders, which
render the entire scene as black, except for the single square light
source.

Resolves #988
Resolves #1317
@hollasch
Copy link
Collaborator

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hollasch hollasch

Labels
book 3: Your Life level: patch
Projects
None yet
Milestone
v4.0.0
Development

No branches or pull requests
2 participants
@hollasch @trevordblack