Aphrodite JSS deprecation #559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it into the tooltip constructor
|
You're close on the commit message format, but not quite 😄 |
Argh, supposed to be the easiest part! Fixed. |
roggervalf
suggested changes
Mar 8, 2020
src/utils/uuid.js
Outdated
| */ | ||
|
|
||
| export function generateUUID(){ | ||
| var dt = new Date().getTime(); |
There was a problem hiding this comment.
this could be replace by a let variable
src/utils/uuid.js
Outdated
| var dt = new Date().getTime(); | ||
|
|
||
| var uuid = "xxxxxxxx-xxxx-4xxx-yxxx-xxxxxxxxxxxx".replace(/[xy]/g, (c) => { | ||
| var r = (dt + Math.random()*16)%16 | 0; |
src/utils/uuid.js
Outdated
| export function generateUUID(){ | ||
| var dt = new Date().getTime(); | ||
|
|
||
| var uuid = "xxxxxxxx-xxxx-4xxx-yxxx-xxxxxxxxxxxx".replace(/[xy]/g, (c) => { |
|
Additionally, added the no-var eslint rule that prevents the further contributors from using var instead of const or let. |
roggervalf
approved these changes
Mar 10, 2020
|
🎉 This PR is included in version 4.0.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 4.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @Rogger794,
I have replaced the *aphrodite-jss implementation with a custom styling solution that does not require any external dependencies.
Tested locally and with the gh-pages branch, works correctly.
The unit tests have been updated accordingly.
No changes in workflows or documentation.
Thank you for your time and have a wonderful day.