Skip to content

Add extra checks during the construction of a generic node #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bvdmitri merged 4 commits into from
Apr 30, 2024
Merged

Add extra checks during the construction of a generic node #396

bvdmitri merged 4 commits into from
Apr 30, 2024

Conversation

@bvdmitri
Copy link
Member

@bvdmitri bvdmitri commented Apr 29, 2024

This PR adds extra check for the creation of nodes, which were defined with the @node macro:

  • Extra check that supplied interfaces are non-empty
  • Extra check that adjacent interfaces have distinct names
  • Extra check that number of input arguments matches with the node definition

Fixes #395

@bvdmitri bvdmitri requested a review from albertpod April 29, 2024 08:54
@bvdmitri bvdmitri merged commit 0c16753 into main Apr 30, 2024
@bvdmitri bvdmitri deleted the generic-node-check-input-arguments branch April 30, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albertpod albertpod albertpod approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Clarification needed on error handling when model is misspecified

3 participants

@bvdmitri @albertpod