Skip to content

Conversation

@ismailsenoz
Copy link
Contributor

Description

This PR implements the Multinomial-Polya node using Polya-Gamma augmentation for inference. The implementation includes:

  • Polya-Gamma augmented inference for the multinomial likelihood
  • Logistic stick-breaking transformation for probability simplex parameterization
  • Support for both analytical expectations and Monte Carlo sampling for omega parameters
  • Efficient computation of natural parameters for the likelihood

@bvdmitri bvdmitri requested a review from Nimrais February 3, 2025 09:22
@codecov
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 92.30769% with 5 lines in your changes missing coverage. Please review.

Project coverage is 74.63%. Comparing base (b88de4d) to head (fcd0193).
Report is 38 commits behind head on main.

Files with missing lines Patch % Lines
src/nodes/predefined/multinomial_polya.jl 93.87% 3 Missing ⚠️
src/rules/multinomial_polya/psi.jl 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #445      +/-   ##
==========================================
+ Coverage   74.42%   74.63%   +0.20%     
==========================================
  Files         195      198       +3     
  Lines        5623     5688      +65     
==========================================
+ Hits         4185     4245      +60     
- Misses       1438     1443       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ismailsenoz ismailsenoz removed the request for review from Nimrais February 25, 2025 08:54
@ismailsenoz ismailsenoz requested a review from bvdmitri February 25, 2025 08:54
@bvdmitri bvdmitri merged commit 5f021c0 into main Feb 26, 2025
6 checks passed
@bvdmitri bvdmitri deleted the multinomial_polya branch February 26, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants