Skip to content

Marble diagram improvements #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
samuelgruetter opened this issue Oct 2, 2013 · 4 comments
Closed

Marble diagram improvements #419

samuelgruetter opened this issue Oct 2, 2013 · 4 comments

Comments

@samuelgruetter
Copy link
Contributor

Many thanks @DavidMGross for all these nice marble diagrams, they're awesome!

Here are some suggestions for improvements:

  • interval: starts at 0, not at 1
  • flatMap/mapMany: make clear that there's an underlying merge (currently it looks as if the items of observable i+1 were only emitted once observable i has completed)
  • where/filter: it might be nicer if the predicate was a shape
  • scan: also show that if frequency of source observable is lower than sampling frequency, elements are repeated
  • zip: it looks like this operator can fetch elements from the future ;-)
  • Make the diagrams open source
@DavidMGross
Copy link
Collaborator

Thanks for the feedback! I'll make the adjustments you suggest.

The diagrams are already open-source:
https://raw.github.com/wiki/Netflix/RxJava/images/rx-operators.graffle though
they're in a proprietary format (http://www.omnigroup.com/omnigraffle)

On Wed, Oct 2, 2013 at 1:43 AM, samuelgruetter [email protected]:

Many thanks @DavidMGross https://github.com/DavidMGross for all these
nice marble diagrams, they're awesome!

Here are some suggestions for improvements:

  • interval: starts at 0, not at 1
  • flatMap/mapMany: make clear that there's an underlying merge
    (currently it looks as if the items of observable i+1 were only
    emitted once observable i has completed)
  • where/filter: it might be nicer if the predicate was a shape
  • scan: also show that if frequency of source observable is lower than
    sampling frequency, elements are repeated
  • zip: it looks like this operator can fetch elements from the future
    ;-)
  • Make the diagrams open source


Reply to this email directly or view it on GitHubhttps://github.com//issues/419
.

@DavidMGross
Copy link
Collaborator

Could you clarify what you meant about "scan" and its sampling frequency?
Did you mean "sample" or one of the "throttle"s?

On Fri, Oct 4, 2013 at 11:33 AM, David Gross [email protected] wrote:

Thanks for the feedback! I'll make the adjustments you suggest.

The diagrams are already open-source:
https://raw.github.com/wiki/Netflix/RxJava/images/rx-operators.graffle though
they're in a proprietary format (http://www.omnigroup.com/omnigraffle)

On Wed, Oct 2, 2013 at 1:43 AM, samuelgruetter [email protected]:

Many thanks @DavidMGross https://github.com/DavidMGross for all these
nice marble diagrams, they're awesome!

Here are some suggestions for improvements:

  • interval: starts at 0, not at 1
  • flatMap/mapMany: make clear that there's an underlying merge
    (currently it looks as if the items of observable i+1 were only
    emitted once observable i has completed)
  • where/filter: it might be nicer if the predicate was a shape
  • scan: also show that if frequency of source observable is lower
    than sampling frequency, elements are repeated
  • zip: it looks like this operator can fetch elements from the future
    ;-)
  • Make the diagrams open source


Reply to this email directly or view it on GitHubhttps://github.com//issues/419
.

@samuelgruetter
Copy link
Contributor Author

oh yes I meant "sample", not "scan"

@samuelgruetter
Copy link
Contributor Author

Thank you @DavidMGross for fixing these in #527

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants