Skip to content

Performance optimizations. #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

benjchristensen
Copy link
Member

  • memoize dynamic function constructions so executions are statically typed after a single dynamic lookup instead of dynamic on every execution
  • use chained observable to reduce composition costs (execute list of functions rather than compositionally invoking onNext)

- memoize dynamic function constructions so executions are statically typed after a single dynamic lookup instead of dynamic on every execution
- use chained observable to reduce composition costs (execute list of functions rather than compositionally invoking onNext)
@benjchristensen
Copy link
Member Author

This pull request is for #104.

I have NOT tried this on production code yet, but all unit tests are working.

I'd like to get code reviews and feedback on the approach before I merge.

@benjchristensen
Copy link
Member Author

NOTE: This is only taking effect on map calls right now. I want to prove it there and then apply to other functions.

It is more or less hacked in on this branch to allow discussion before I do the fairly substantial refactor to apply this pattern elsewhere.

There are also more complicated use cases still to deal with.

@benjchristensen
Copy link
Member Author

I removed the prototype of chaining. This is currently at a clean point that could merge over the dynamic function invocation optimizations.

I am playing more with chaining.

@benjchristensen
Copy link
Member Author

Cleaned up in new pull request with single commit with just function execution optimizations.

#106

Will not merge this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant