Skip to content

Hardened both cache() and replay() against child-thrown exceptions. #3088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Hardened both cache() and replay() against child-thrown exceptions. #3088

wants to merge 1 commit into from

Conversation

akarnokd
Copy link
Member

  • Made cache() more eager to check for unsubscription in its replay loop
  • Fixed autoConnect() triggering a second call to onStart
  • Added cache() tests to see replay().autoConnect() works equivalently.
  • Changed the way cache() connects to the source, removed unnnecessary synchronization of incoming events.

@akarnokd akarnokd mentioned this pull request Jul 17, 2015
Closed
@akarnokd akarnokd force-pushed the CacheFixAttempt branch 2 times, most recently from 6cc7b23 to 4190d8e Compare July 17, 2015 18:08
@abersnaze
Copy link
Contributor

Just checked on the canary and it didn't seem to change the slope of the line.

@akarnokd
Copy link
Member Author

Could you try this PR and use replay().autoConnect() in Observable.cache()?

@akarnokd akarnokd closed this Jul 23, 2015
@akarnokd akarnokd deleted the CacheFixAttempt branch September 9, 2015 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akarnokd @abersnaze