Skip to content

Conversation

@JakeWharton
Copy link
Contributor

No description provided.

@JakeWharton JakeWharton changed the title Normalize request validation using SubscriptionHelper. 2.x: Normalize request validation using SubscriptionHelper. Jun 23, 2016
@JakeWharton
Copy link
Contributor Author

This method is super weird with true indicating invalid and false indicating valid.

@codecov-io
Copy link

Current coverage is 69.97%

Merging #4087 into 2.x will increase coverage by 0.05%

@@                2.x      #4087   diff @@
==========================================
  Files           383        383          
  Lines         27074      27057    -17   
  Methods           0          0          
  Messages          0          0          
  Branches       4342       4342          
==========================================
+ Hits          18931      18933     +2   
+ Misses         6230       6216    -14   
+ Partials       1913       1908     -5   

Powered by Codecov. Last updated by 66ce4d5...c092119

@akarnokd
Copy link
Member

I agree, looked like a good idea back then to flip. I think it should be straight: true means valid. Would you like to do the flip?

@akarnokd akarnokd merged commit 0dadfe3 into ReactiveX:2.x Jun 23, 2016
@JakeWharton
Copy link
Contributor Author

Yep. I'll add it to my list.

On Thu, Jun 23, 2016 at 3:04 AM David Karnok [email protected]
wrote:

Merged #4087 #4087.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#4087 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAEEEdQ8kWZzmmsrGSOiZ7L4IJ-QwGSdks5qOi_4gaJpZM4I8d58
.

@akarnokd akarnokd added this to the 2.0 RC 1 milestone Jun 23, 2016
@JakeWharton JakeWharton deleted the jw/request-validation branch August 20, 2016 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants