Skip to content

2.x: Parallelize unit test execution for speed! #4113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2016
Merged

2.x: Parallelize unit test execution for speed! #4113

merged 1 commit into from
Jun 25, 2016

Conversation

JakeWharton
Copy link
Contributor

This gives me a 57% reduction in execution time.

@JakeWharton
Copy link
Contributor Author

Looks like Travis can't handle it. I can disable it for CI builds where build speed isn't really important.

@codecov-io
Copy link

Current coverage is 69.93%

Merging #4113 into 2.x will decrease coverage by 0.02%

@@                2.x      #4113   diff @@
==========================================
  Files           380        380          
  Lines         27005      27005          
  Methods           0          0          
  Messages          0          0          
  Branches       4345       4345          
==========================================
- Hits          18894      18887     -7   
- Misses         6203       6206     +3   
- Partials       1908       1912     +4   

Powered by Codecov. Last updated by e5b0b06...c1b607c

@akarnokd
Copy link
Member

This increases the likelihood of timeouts during heavy times. Maybe later.

@akarnokd
Copy link
Member

In addition, some tests may conflict because they may change the global hooks. I'm guessing there isn't a JUnit annotation that allows some tests to run in parallel with others while forbidding for others?

@JakeWharton
Copy link
Contributor Author

They run in forked JVMs so any static state won't clash.

On Sat, Jun 25, 2016, 6:23 AM David Karnok [email protected] wrote:

In addition, some tests may conflict because they may change the global
hooks. I'm guessing there isn't a JUnit annotation that allows some tests
to run in parallel with others while forbidding for others?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#4113 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAEEEXipt9AbKh48TvcYX66NfjDdqomDks5qPQGlgaJpZM4I-NeJ
.

@akarnokd akarnokd added this to the 2.0 RC 1 milestone Jun 25, 2016
@akarnokd
Copy link
Member

Okay, let's try it.

@akarnokd akarnokd merged commit 0287d55 into ReactiveX:2.x Jun 25, 2016
@JakeWharton JakeWharton deleted the jw/must-go-faster branch August 20, 2016 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants