2.x: add javadoc and unit test to the recently changed XTransformers #4674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akarnokd
changed the title
vanniktech
reviewed
Oct 6, 2016
| @@ -22,5 +22,13 @@ | |||
| * @param <Downstream> the downstream value type | |||
| */ | |||
| public interface FlowableTransformer<Upstream, Downstream> { | |||
| Publisher<? extends Downstream> apply(Flowable<Upstream> flowable) throws Exception; | |||
| /** | |||
| * Applies a function to the upstream flowable and returns a Publisher with | |||
There was a problem hiding this comment.
nit: uppercase Flowable
|
We may have to drop jacoco as it kills builds 1 out of 3. |
Current coverage is 81.96% (diff: 100%)@@ 2.x #4674 diff @@
==========================================
Files 565 565
Lines 37414 37414
Methods 0 0
Messages 0 0
Branches 5746 5746
==========================================
- Hits 30715 30666 -49
- Misses 4619 4658 +39
- Partials 2080 2090 +10
|
JakeWharton
approved these changes
Oct 6, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the javadoc and crash-testing for each XTransformer interface changed by #4672.