Skip to content

Fix issue #6576 - ObservableBlockingSubscribe compares BlockingObserver.TERMINATED with wrong object #6577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2019

Conversation

Erlkoenig90
Copy link
Contributor

Fix #6576 , compare with v instead of o.

…ingObserver.TERMINATED with wrong object
@akarnokd akarnokd added this to the 3.0 milestone Jul 17, 2019
@codecov
Copy link

codecov bot commented Jul 17, 2019

Codecov Report

Merging #6577 into 3.x will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #6577      +/-   ##
============================================
+ Coverage     98.21%   98.22%   +<.01%     
- Complexity     6184     6186       +2     
============================================
  Files           678      678              
  Lines         44900    44900              
  Branches       6211     6211              
============================================
+ Hits          44099    44101       +2     
- Misses          263      268       +5     
+ Partials        538      531       -7
Impacted Files Coverage Δ Complexity Δ
...rators/observable/ObservableBlockingSubscribe.java 97.14% <ø> (ø) 9 <0> (ø) ⬇️
...ava/io/reactivex/processors/BehaviorProcessor.java 96.58% <0%> (-2.44%) 51% <0%> (ø)
...va/io/reactivex/internal/queue/SpscArrayQueue.java 97.61% <0%> (-2.39%) 22% <0%> (-1%)
...ernal/operators/flowable/FlowableFlatMapMaybe.java 91.3% <0%> (-1.45%) 2% <0%> (ø)
...ex/internal/operators/flowable/FlowableCreate.java 96.45% <0%> (-1.3%) 6% <0%> (ø)
...ternal/operators/completable/CompletableMerge.java 96.42% <0%> (-1.2%) 2% <0%> (ø)
...rnal/operators/flowable/FlowableFlatMapSingle.java 95.65% <0%> (-1.09%) 2% <0%> (ø)
...ernal/operators/flowable/FlowableFromIterable.java 95.18% <0%> (-1.07%) 5% <0%> (ø)
...perators/observable/ObservableMergeWithSingle.java 99.06% <0%> (-0.94%) 2% <0%> (ø)
...perators/mixed/ObservableConcatMapCompletable.java 99.24% <0%> (-0.76%) 3% <0%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a38268c...92c8fdd. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ObservableBlockingSubscribe compares BlockingObserver.TERMINATED with wrong object
2 participants