Skip to content

3.x: Fix size+time bound window not creating windows properly #6652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2019

Conversation

akarnokd
Copy link
Member

There was a logic error in the size+time bound window operator for when to close a window if timers are not restarted when the size-bound is hit.

Due to this bug, two tests were not receiving and thus accounting for empty windows that are happening when the size-bound is hit followed by the periodic time-bound hit.

2.x will be fixed in a separate PR.

Fixes #6651

@akarnokd akarnokd added this to the 3.0 milestone Sep 12, 2019
@codecov
Copy link

codecov bot commented Sep 12, 2019

Codecov Report

❗ No coverage uploaded for pull request base (3.x@9a36930). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##             3.x    #6652   +/-   ##
======================================
  Coverage       ?   98.12%           
  Complexity     ?     6193           
======================================
  Files          ?      678           
  Lines          ?    44722           
  Branches       ?     6176           
======================================
  Hits           ?    43885           
  Misses         ?      290           
  Partials       ?      547
Impacted Files Coverage Δ Complexity Δ
...ternal/operators/flowable/FlowableWindowTimed.java 91.4% <100%> (ø) 4 <0> (?)
...al/operators/observable/ObservableWindowTimed.java 90.73% <100%> (ø) 4 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a36930...2e7a826. Read the comment docs.

@akarnokd akarnokd merged commit 6518eb9 into ReactiveX:3.x Sep 17, 2019
@akarnokd akarnokd deleted the WindowTimeAndSizeFix3x branch September 17, 2019 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants