Skip to content

Conversation

@zsxwing
Copy link
Member

@zsxwing zsxwing commented Mar 25, 2015

No description provided.

@samuelgruetter
Copy link
Collaborator

In RxJava, both onBackpressureDrop methods (the one with and the one without an action) have the same name, but in RxScala, you introduce the ugly name onBackpressureDropWithDropAction. I guess that's because otherwise the implicit conversion to ExperimentalAPI doesn't kick in? Or would it not even work if it was directly in Observable?

@zsxwing
Copy link
Member Author

zsxwing commented Mar 25, 2015

It's because overload and implicit conversion cannot work together. Better name? Or we should consider another approach to add experimental APIs?

@zsxwing
Copy link
Member Author

zsxwing commented Mar 27, 2015

@samuelgruetter how about I just update RxJava? I would like to release a new version to test the build scripts.

@samuelgruetter
Copy link
Collaborator

As you wish ;-) Or I'd also be fine with renaming onBackpressureDropWithDropAction into something better (but what...?)

@zsxwing
Copy link
Member Author

zsxwing commented Mar 27, 2015

onBackpressureDropWith or onBackpressureDropWithAction?

@jbripley
Copy link
Contributor

onBackpressureDropDo would be somewhat analogues with the doOn*(Action) methods?

@zsxwing
Copy link
Member Author

zsxwing commented Mar 30, 2015

onBackpressureDropDo would be somewhat analogues with the doOn*(Action) methods?

I think onBackpressureDropDo is better. @samuelgruetter thoughts?

@samuelgruetter
Copy link
Collaborator

+1 for onBackpressureDropDo

@zsxwing
Copy link
Member Author

zsxwing commented Mar 30, 2015

Updated the method name.

@zsxwing zsxwing changed the title Update to Rxjava 1.0.8 & add onBackpressureDropWithDropAction to ExperimentalAPIs Update to Rxjava 1.0.8 & add onBackpressureDropDo to ExperimentalAPIs Mar 30, 2015
@samuelgruetter
Copy link
Collaborator

LGTM

zsxwing added a commit that referenced this pull request Mar 30, 2015
Update to Rxjava 1.0.8 & add onBackpressureDropDo to ExperimentalAPIs
@zsxwing zsxwing merged commit 7625a29 into ReactiveX:0.x Mar 30, 2015
@zsxwing zsxwing deleted the rxjava-1.0.8 branch March 30, 2015 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants