Skip to content

Conversation

@elegoff
Copy link
Contributor

@elegoff elegoff commented May 6, 2015

After an update on OnCompleted (elegoff@ebff7cc) the example does not work if used without a small change for pattern matching

After an update on OnCompleted (ebff7cc) the example does not work if used without a small change for pattern matching
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@zsxwing zsxwing changed the title Update Notification.scala Update the out-of-date example in "Notification" doc May 6, 2015
changing Observable(1, 2, 3) to Observable.just(1, 2, 3) in the example
zsxwing added a commit that referenced this pull request May 7, 2015
Update the out-of-date example in "Notification" doc
@zsxwing zsxwing merged commit b418590 into ReactiveX:0.x May 7, 2015
@zsxwing
Copy link
Member

zsxwing commented May 7, 2015

LGTM. Merged. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants