Eliminated two possible false positives from BlockingObservableTest

[illusioni]

No description provided.

[zsxwing]

Could you clarify why you need to change them, such as provide an example of false positives?

[illusioni]

Hi Shixiong Zhu,
The existing test is wrong because it does not test all that's specified.
It only works because the component under test (CUT) behaves well.
In the case of the "toFuture function throwing rather than producing a failing future" the existing test would still succeed (that's the false positive).
My version of the test would fail - as a test should when the CUT does not comply with the spec.
Hope that info helps. :-)
Big fan of Rx by now...
Klaus
On Oct 6, 2015 17:00, Shixiong Zhu [email protected] wrote:Could you clarify why you need to change them, such as provide an example of false positives?

—Reply to this email directly or view it on GitHub.

[zsxwing]

nit: NoSuchElementException -> IllegalArgumentException

[zsxwing]

@illusioni Thanks for your clarification. I will merge this PR once you fix the typo.

[illusioni]

I tried hard, @zsxwing, but I can't find a typo in my changes.
Please let me know where you see an error

[illusioni]

Aaah. Is this what you meant?

[zsxwing]

@illusioni Exactly. Thanks! Merged.