Fix the wrong return type of `take` overload with scheduler #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

zsxwing merged 1 commit into ReactiveX:0.x from jking-roar:patch-1

Jul 14, 2016

Contributor

jking-roar commented Jun 29, 2016

fixes signature of method with erroneous Unit return type


          take with scheduler returns an Observable

aaafa90

fixes signature of method with erroneous Unit return type

Member

zsxwing commented Jun 29, 2016

Good catch. Thanks! Could you also add a simple example in https://github.com/ReactiveX/RxScala/blob/0.x/examples/src/test/scala/examples/RxScalaDemo.scala to test the signature?

zsxwing merged commit c17b434 into ReactiveX:0.x

Member

zsxwing commented Jul 14, 2016

Thanks! @jking-roar

zsxwing changed the title ~~take with scheduler returns an Observable~~ Fix the wrong return type of take overload with scheduler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet