Upgrade to RxJava 1.1.9 and add missing operators #204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
However, this commit's test is failed because there are various changes between 1.1.6 and 1.1.9, and I cannot decide about these problems myself. Something Problems: In rx.Scheduler, `when` method was appended. In rx.Observable, 24 methods are appended. And, While I put assertValuesAndClear's test into SubscriberTests, but you should move to appropriate place for this test or remove if this test is not needed. You should consider this commit as reference or it would be better to create your own from scratch.
| import org.scalatest.junit.JUnitSuite | ||
| import rx.lang.scala._ | ||
| import rx.lang.scala.schedulers.TestScheduler | ||
| import rx.observers.TestObserver |
Member
Author
There was a problem hiding this comment.
TestObserver is deprecated.
| @Experimental | ||
| def getCompletions: Int = { | ||
| jTestSubscriber.getCompletions | ||
| } |
Collaborator
There was a problem hiding this comment.
getXxx method names are not so Scala-typical... Why not just completions?
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.