Add UnicastSubject #213
Merged
Add UnicastSubject #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelgruetter
requested changes
Oct 18, 2016
| * requests a limited amount, queueing is involved and only those values are retained which | ||
| * weren't requested by the `Subscriber` at that time. | ||
| */ | ||
| @Experimental |
Collaborator
There was a problem hiding this comment.
Putting the @Experimental annotation here is fine, but in addition, you could also add a red badge in the scaladoc comment, as in ErrorDelayingObservable.
Contributor
Author
There was a problem hiding this comment.
Done, it looks fine!
Member
There was a problem hiding this comment.
@ruippeixotog you forgot to add $experimental to the class doc.
Contributor
Author
There was a problem hiding this comment.
Done. I also added @Experimental to the methods in order to be consistent with what was done in ErrorDelayingObservable.
ruippeixotog
force-pushed
the
unicast-subject
branch
2 times, most recently
from
3494dba to
55aff5e
Compare
ruippeixotog
force-pushed
the
unicast-subject
branch
from
55aff5e to
4e50524
Compare
samuelgruetter
approved these changes
Oct 18, 2016
Member
|
👍 |
Member
|
Thanks @ruippeixotog |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a wrapper for JavaRx
UnicastSubject. Although theSubjectis experimental, I would like to see a Scala wrapper for it as it's very useful in one of my projects.I read #100, but I'm still not sure of how I should mark classes as experimental. I opted to use the annotation that is used in Java, but please tell me if you want it another way and I'll change it.