Skip to content

Conversation

@zsxwing
Copy link
Member

@zsxwing zsxwing commented Dec 9, 2014

As per #77

@samuelgruetter
Copy link
Collaborator

Are you sure that this is "the right way" to do it? Can you answer the question I asked in #77 (comment)? And somehow, Java and Scala are compatible, can we exploit this better? The following compiles:

val ec: java.util.concurrent.Executor = scala.concurrent.ExecutionContext.Implicits.global

And do we also have to care about ExecutorServices?
I'd prefer adding nothing than something we don't understand...

@zsxwing
Copy link
Member Author

zsxwing commented Dec 10, 2014

Answered in #77

@zsxwing
Copy link
Member Author

zsxwing commented Mar 24, 2015

@samuelgruetter could you revisit this PR? I added unit tests to verify the thread name. For ExecutionContextExecutor, since it's already a java.util.concurrent.Executor, we don't need to wrap it.

@zsxwing
Copy link
Member Author

zsxwing commented Mar 24, 2015

Updated the examples.

@samuelgruetter
Copy link
Collaborator

LGTM

zsxwing added a commit that referenced this pull request Mar 24, 2015
Add ExecutionContextScheduler for Scala ExecutionContext
@zsxwing zsxwing merged commit 743b293 into ReactiveX:0.x Mar 24, 2015
@zsxwing zsxwing deleted the executor branch March 24, 2015 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants