-
Notifications
You must be signed in to change notification settings - Fork 18
uncap numpy and raise minimum numba version #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughUpdated dependency constraints in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "numba>=0.62.0", | ||
| "datasets>=4.0.0", | ||
| "numpy>=1.26.4,<2.3", | ||
| "numpy>=1.26.4", | ||
| "rich>=14.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
Align llvmlite constraint with Numba 0.62.0.
Numba 0.62.0 hard-pins llvmlite to the 0.49.x line (>=0.49,<0.50). Leaving our direct requirement at >=0.42 means the resolver may try to pull an incompatible llvmlite (e.g., 0.50+ once released) and fail the install, or worse, reuse an already-installed 0.42.x when installing with --no-deps. Please tighten our constraint to match Numba’s supported range so environments resolve deterministically.
Run this to confirm the exact pins published with Numba 0.62.0:
🏁 Script executed:
#!/bin/bash
# Inspect numba 0.62.0 metadata for llvmlite requirements
curl -s https://pypi.org/pypi/numba/0.62.0/json | jq -r '.info.requires_dist[]' | rg llvmliteLength of output: 26
🏁 Script executed:
#!/bin/bash
rg -n 'llvmlite' -C1 pyproject.tomlLength of output: 72
Align llvmlite constraint to Numba 0.62.0 requirements
Numba 0.62.0 pins llvmlite to >=0.45.0dev0,<0.46. In pyproject.toml, change
"llvmlite>=0.42"
to
"llvmlite>=0.45.0dev0,<0.46"
to ensure dependency compatibility.
🤖 Prompt for AI Agents
In pyproject.toml around lines 21 to 24, update the llvmlite constraint to match
Numba 0.62.0 requirements: replace the current "llvmlite>=0.42" entry with
"llvmlite>=0.45.0dev0,<0.46" so the declared dependency range is compatible with
Numba 0.62.0 and prevents incompatible llvmlite versions from being selected.
Based on similar prs in mini trainer and training hub
Summary by CodeRabbit