Skip to content

Conversation

@RobotSail
Copy link
Collaborator

@RobotSail RobotSail commented Oct 11, 2025

Based on similar prs in mini trainer and training hub

Summary by CodeRabbit

  • Chores
    • Updated dependency constraints for core numerical libraries to allow newer versions.
    • Raised the minimum required version of a JIT compiler library to improve compatibility and performance.
    • Removed an upper version limit for the core array library to reduce installation conflicts and improve forward compatibility.
    • No changes to public APIs or user-facing behavior.

@coderabbitai
Copy link

coderabbitai bot commented Oct 11, 2025

Walkthrough

Updated dependency constraints in pyproject.toml: bumped numba to >=0.62.0 and removed the upper bound on numpy (now >=1.26.4). No other files or public APIs were changed.

Changes

Cohort / File(s) Summary of Changes
Dependency constraints
pyproject.toml
Bumped numba to >=0.62.0 (was >=0.50); removed the upper bound on numpy making it >=1.26.4 (was >=1.26.4,<2.3). No other edits.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I twitch my whiskers, bump the bounds,
Numba hops faster through the grounds.
NumPy's leash grows soft and long—
I dance a quick, approving song.
Carrot cheers beneath the moonlight bright. 🥕✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title succinctly and accurately describes the primary updates in the pull request, which are removing the numpy version cap and increasing the minimum numba version. It uses clear and concise language that directly aligns with the changes in pyproject.toml without extraneous detail.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch uncap-numpy

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ed4cb74 and 889716f.

📒 Files selected for processing (1)
  • pyproject.toml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • pyproject.toml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fc2175d and ed4cb74.

📒 Files selected for processing (1)
  • pyproject.toml (1 hunks)

Comment on lines 21 to 24
"numba>=0.62.0",
"datasets>=4.0.0",
"numpy>=1.26.4,<2.3",
"numpy>=1.26.4",
"rich>=14.1.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

Align llvmlite constraint with Numba 0.62.0.

Numba 0.62.0 hard-pins llvmlite to the 0.49.x line (>=0.49,<0.50). Leaving our direct requirement at >=0.42 means the resolver may try to pull an incompatible llvmlite (e.g., 0.50+ once released) and fail the install, or worse, reuse an already-installed 0.42.x when installing with --no-deps. Please tighten our constraint to match Numba’s supported range so environments resolve deterministically.

Run this to confirm the exact pins published with Numba 0.62.0:


🏁 Script executed:

#!/bin/bash
# Inspect numba 0.62.0 metadata for llvmlite requirements
curl -s https://pypi.org/pypi/numba/0.62.0/json | jq -r '.info.requires_dist[]' | rg llvmlite

Length of output: 26


🏁 Script executed:

#!/bin/bash
rg -n 'llvmlite' -C1 pyproject.toml

Length of output: 72


Align llvmlite constraint to Numba 0.62.0 requirements

Numba 0.62.0 pins llvmlite to >=0.45.0dev0,<0.46. In pyproject.toml, change

"llvmlite>=0.42"

to

"llvmlite>=0.45.0dev0,<0.46"

to ensure dependency compatibility.

🤖 Prompt for AI Agents
In pyproject.toml around lines 21 to 24, update the llvmlite constraint to match
Numba 0.62.0 requirements: replace the current "llvmlite>=0.42" entry with
"llvmlite>=0.45.0dev0,<0.46" so the declared dependency range is compatible with
Numba 0.62.0 and prevents incompatible llvmlite versions from being selected.

@RobotSail RobotSail merged commit 95b88b9 into main Oct 13, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants