fix(navigation primary): secondary items fit content at #2405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Deploy Preview for red-hat-design-system ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Size Change: +238 B (+0.1%) Total Size: 231 kB
ℹ️ View Unchanged
|
|
Can we do this with CSS only? Adding SSR complexity to this element specifically is likely to have downstream implications. This also subtly breaks the already accepted designs, so we shouldn't add this feature in any regard, without design and PM input. |
I'm not sure we should do it at all. I agree with it breaking the accepted designs, and would prefer these changes be formally requested by design first if there is an issue with the component as is. For these reasons, the PR remains in draft. I added the "hold" status to it. This was in response to a "bug/can we have" report by the RHDC team, but upon reviewing the details and the design originally provided, I'm not convinced yet either. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
menu-fit-content-atattributes. Allows secondary items to change when they move from mobile full-screen tofit-contentwidthTODO:
compact(padding changes) and these new breakpointsstaging/diglettdue to this change being aminorhide-at.Breaking? If so, we may want to revert that commit and open an issue for the change on the next available major.Testing Instructions
Notes to Reviewers
ts.