fix(navigation-primary): hamburger standalones toggle state #2462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 55b7f81 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
❌ Deploy Preview for red-hat-design-system failed. Why did it fail? →
|
|
Size Change: -71 B (-0.03%) Total Size: 235 kB
ℹ️ View Unchanged
|
zeroedin
changed the title
adamjohnson
reviewed
Jul 3, 2025
There was a problem hiding this comment.
The closing behavior of the menu toggle on the left is different than the search and "For you" toggles on the right. Eg:
- < 1200px, tab from the Red Hat logo to the menu toggle
- Open the menu toggle via the Enter key
- Hit tab to set focus to "AI"
- Hit shift + tab to return focus to the menu toggle. (Menu closes)
Contrast this behavior to Search / For You, when shift tabbing from inside the open dropdown, the dropdown stays open.
This is not necessarily a blocker, just a curious difference between the two menus.
Good catch, this shouldn't be different, you are correct, I don't believe we should be closing the menu until we leave entirely the focus of the "summary" itself eg from menu back to logo, or from contents of menu to the next menu or item in the nav bar.. |
…yDropdowns it is used
adamjohnson
approved these changes
Jul 7, 2025
bennypowers
reviewed
Jul 14, 2025
There was a problem hiding this comment.
@adamjohnson can you just quickly validate the jsdocs i added?
bennypowers
approved these changes
Jul 14, 2025
bennypowers
deleted the
fix/navigation-primary/toggle-state-hamburger-standalones
branch
github-project-automation
bot
moved this from Review 🔍
to Done ☑️
in Red Hat Design System
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Reported by @zhawkins 🙇
Testing Instructions
Notes to Reviewers