chore: Move interactive terminal detection to own package #270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@m-horky This PR has conflicts with main branch. Please resolve these conflicts. |
* Card ID: CCT-1587 This patch removes big part of terminal and output-related logic into its own package. This will allow us to decouple CLI and business logic from each other later.
m-horky
force-pushed
the
mhorky/refactor-interactive
branch
from
72cae87 to
6c75484
Compare
|
I'm assuming we'll get another conflict after #269 is merged. I'll deal with it when it happens. |
* Card ID: CCT-1587 - Move 'interactivePrintf' to 'ui.Printf' - Move 'showProgress' to 'ui.Spinner' By moving these methods, we decouple presentation from UI logic a bit better. Different names have been picked to better describe their functions.
|
Questions for the review to consider:
|
m-horky
force-pushed
the
mhorky/refactor-interactive
branch
from
6c75484 to
872bf4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes big part of terminal and output-related logic into its own package. This will allow us to decouple CLI and business logic from each other later.
This patch deviates from the original implementation by separating the no-color preference from rich experience like interactive input and spinners.