Skip to content

Start a random slot in the case of cluster benchmarks and commands without key #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
filipecosta90 merged 2 commits into from
Mar 31, 2023
Merged

Start a random slot in the case of cluster benchmarks and commands without key #89

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d40405c
Start a random slot in the case of cluster benchmarks and commands wi…
filipecosta90 Mar 31, 2023
40673d1
Merge remote-tracking branch 'origin/master' into fix.roundrobin
filipecosta90 Mar 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions cmd/ftsb_redisearch/cmd_processor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import (
radix "github.com/mediocregopher/radix/v3"
"golang.org/x/time/rate"
"log"
"math/rand"
"strconv"
"strings"
"sync"
Expand Down Expand Up @@ -85,6 +86,8 @@ func connectionProcessor(p *processor, rateLimiter *rate.Limiter, useRateLimiter
}
}
clusterAddrLen = len(clusterSlots)
// start at a random slot between 0 and clusterAddrLen
slotP = rand.Intn(clusterAddrLen)
Copy link

@sonatype-lift sonatype-lift bot Mar 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

12% of developers fix this issue

G404: Use of weak random number generator (math/rand instead of crypto/rand)

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.

Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? Answering this survey will not impact your Lift settings.

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

}

for row := range p.rows {
Expand Down