Skip to content

fix #171 : Add missing FieldOptions in FT.INFO command #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 19, 2022

Conversation

shumin1027
Copy link
Contributor

fix #171 : The Info() method missing FieldOptions info

@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Merging #172 (2082c9c) into master (81cf501) will decrease coverage by 0.46%.
The diff coverage is 64.28%.

❗ Current head 2082c9c differs from pull request most recent head 98322ca. Consider uploading reports for the commit 98322ca to get more accurate results

@@            Coverage Diff             @@
##           master     #172      +/-   ##
==========================================
- Coverage   82.92%   82.46%   -0.47%     
==========================================
  Files          13       13              
  Lines        1441     1460      +19     
==========================================
+ Hits         1195     1204       +9     
- Misses        195      199       +4     
- Partials       51       57       +6     
Impacted Files Coverage Δ
redisearch/client.go 81.38% <64.28%> (-1.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81cf501...98322ca. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Avital-Fine Avital-Fine changed the title fix #171 : The Info() method missing FieldOptions info fix #171 : Add missing FieldOptions in FT.INFO command Jul 19, 2022
Copy link
Contributor

@Avital-Fine Avital-Fine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Sorry for all the commits, the change was minor. And Thank you for contributing :)

@Avital-Fine Avital-Fine merged commit d60cb3a into RediSearch:master Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Info() method missing FieldOptions info
2 participants