Move is_empty() in RedisKeyWritable to its rightful place with the documentation.#282
Merged
Conversation
Contributor
Author
|
Ping, any updates? |
iddm
reviewed
May 2, 2023
|
Hey @QuChen88, sorry that it was missed. Lets fix the conflict and merge it. |
Contributor
Author
|
I just did a rebase and fixed conflicts |
MeirShpilraien
approved these changes
Jan 15, 2024
|
Thanks @QuChen88 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the
is_empty()function used to detect if a key is present or not, is way after the Rust documentation for it. This led to the public documentation page to mark that on the wrong API method, which can be misleading. See https://docs.rs/redis-module/latest/redis_module/key/struct.RedisKeyWritable.html