Skip to content

Duplictae policy #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AvitalFineRedis merged 35 commits into from
Apr 14, 2021
Merged

Duplictae policy #40

AvitalFineRedis merged 35 commits into from
Apr 14, 2021

Conversation

@AvitalFineRedis
Copy link
Contributor

@AvitalFineRedis AvitalFineRedis commented Apr 6, 2021

add support for DUPLICATE_POLICY on TS.CREATE and TS.ADD #37

@codecov
Copy link

codecov bot commented Apr 6, 2021 •
edited
Loading

Codecov Report

Merging #40 (b188acf) into master (4baa80a) will decrease coverage by 2.12%.
The diff coverage is 77.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
- Coverage   98.48%   96.36%   -2.13%     
==========================================
  Files          12       13       +1     
  Lines         529      578      +49     
==========================================
+ Hits          521      557      +36     
- Misses          8       21      +13
Impacted Files Coverage Δ
...TimeSeries/Extensions/DuplicatePolicyExtensions.cs 40.00% <40.00%> (ø)
NRedisTimeSeries/TimeSeriesClientResponseParser.cs 97.70% <90.00%> (-0.66%) ⬇️
NRedisTimeSeries/Commands/CommandArgs.cs 100.00% <100.00%> (ø)
...RedisTimeSeries/DataTypes/TimeSeriesInformation.cs 100.00% <100.00%> (ø)
NRedisTimeSeries/TimeSeriesClient.cs 100.00% <100.00%> (ø)
NRedisTimeSeries/TimeSeriesClientAsync.cs 93.65% <100.00%> (ø)
NRedisTimeSeries/TimeSeriesClientAux.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4baa80a...b188acf. Read the comment docs.

@AvitalFineRedis AvitalFineRedis linked an issue Apr 6, 2021 that may be closed by this pull request
Support for DUPLICATE_POLICY on TS.CREATE and TS.ADD #37
Closed
AvitalFineRedis
AvitalFineRedis commented Apr 7, 2021
View reviewed changes
DvirDukhan
DvirDukhan reviewed Apr 11, 2021
View reviewed changes
Copy link

@DvirDukhan DvirDukhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good
few comments

@AvitalFineRedis AvitalFineRedis merged commit 402e7e6 into master Apr 14, 2021
@AvitalFineRedis AvitalFineRedis deleted the duplictae_policy branch April 14, 2021 08:10
@AvitalFineRedis AvitalFineRedis restored the duplictae_policy branch April 18, 2021 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@DvirDukhan DvirDukhan DvirDukhan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@DvirDukhan DvirDukhan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support for DUPLICATE_POLICY on TS.CREATE and TS.ADD

3 participants

@AvitalFineRedis @DvirDukhan