Skip to content

House keeping: Remove legacy office screen#232

Merged
hashtegner merged 5 commits into
masterfrom
remove-legacy-office-screens
Mar 23, 2020
Merged

House keeping: Remove legacy office screen#232
hashtegner merged 5 commits into
masterfrom
remove-legacy-office-screens

Conversation

@hashtegner

@hashtegner hashtegner commented Mar 21, 2020

Copy link
Copy Markdown
Contributor

Context

This PR removes legacy code from old matrix office screen.

All should work, without brakes.
Besides that, we can redirect logged users on the backend, keeping the frontend simple.
On a next PR I will refactor login page to morpheus.

fix: #225

@hashtegner hashtegner force-pushed the remove-legacy-office-screens branch 3 times, most recently from 0aac391 to da8356c Compare March 21, 2020 23:40
@hashtegner hashtegner changed the title [Wip] House keeping: Remove legacy office screen House keeping: Remove legacy office screen Mar 21, 2020
@hashtegner hashtegner self-assigned this Mar 21, 2020
@hashtegner hashtegner marked this pull request as ready for review March 21, 2020 23:46
@hashtegner hashtegner force-pushed the remove-legacy-office-screens branch from da8356c to 55907db Compare March 21, 2020 23:49

@juliemar juliemar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR is related to this issue: #225

@juliemar juliemar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can continue calling the layout Morpheus.

Comment thread backend/app/views/morpheus.ejs
Comment thread backend/app/views/morpheus.ejs Outdated
Comment thread frontend/package.json
@hashtegner hashtegner requested a review from juliemar March 22, 2020 15:14

@juliemar juliemar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hashtegner hashtegner force-pushed the remove-legacy-office-screens branch from b692ae5 to c155487 Compare March 23, 2020 00:58
@hashtegner hashtegner merged commit b33a8a9 into master Mar 23, 2020
@hashtegner hashtegner deleted the remove-legacy-office-screens branch March 23, 2020 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove unused Files

2 participants