Skip to content

es2022 class features #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 3, 2023
Merged

Conversation

jasonlyu123
Copy link
Contributor

Fixes sveltejs/svelte#6900 sveltejs/svelte#6592

Not sure what we should do with a private identifier in the b, x and p functions, so I use parse directly in testing for now. I can add support for the core functions of the escape method of the private identifier is decided.

@Rich-Harris Rich-Harris merged commit 12bfe42 into Rich-Harris:master Mar 3, 2023
@Rich-Harris
Copy link
Owner

Thank you! I don't think it's possible to support private identifiers in b, x and p, since we're effectively squatting on what is now (but wasn't at the time) valid syntax

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeScript Class Attributes Bug
2 participants